From: Moriel Schottlender <moriel@gmail.com>
Date: Tue, 13 Jun 2017 23:04:57 +0000 (-0700)
Subject: RCFilters: Send form info even for empty checkboxes
X-Git-Tag: 1.31.0-rc.0~2989^2
X-Git-Url: http://git.cyclocoop.org/%27.parametre_url%28%20%20%20generer_action_auteur%28%27charger_plugin%27%2C%20%27update_flux%27%29%2C%27update_flux%27%2C%20%27oui%27%29.%27?a=commitdiff_plain;h=89cc9afb772490e67c188adbed09697571a758dc;p=lhc%2Fweb%2Fwiklou.git

RCFilters: Send form info even for empty checkboxes

Make sure the url params override previous ones in case they are
empty, make sure we still send them through the fieldset form with
an empty value, rather than not send them at all (and then they are
being re-merged into the existing URL and become essentially 'sticky')

Change-Id: I294dba17c5a5b792f5bf5064a76dedefa4d12557
---

diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FormWrapperWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FormWrapperWidget.js
index d17fffffe6..7605faeaa6 100644
--- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FormWrapperWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FormWrapperWidget.js
@@ -72,9 +72,13 @@
 
 		// Collect all data from form
 		$( e.target ).find( 'input:not([type="hidden"],[type="submit"]), select' ).each( function () {
+			var value = '';
+
 			if ( !$( this ).is( ':checkbox' ) || $( this ).is( ':checked' ) ) {
-				data[ $( this ).prop( 'name' ) ] = $( this ).val();
+				value = $( this ).val();
 			}
+
+			data[ $( this ).prop( 'name' ) ] = value;
 		} );
 
 		this.controller.updateChangesList( data );