jenkins-bot [Thu, 25 Jul 2019 22:29:33 +0000 (22:29 +0000)]
Merge "Enable RecentChanges modules on mobile"
jdlrobson [Thu, 25 Jul 2019 21:41:58 +0000 (14:41 -0700)]
Enable RecentChanges modules on mobile
Change-Id: I9ec4b70390700cd697faeffd8f70c67e9c542e82
jenkins-bot [Thu, 25 Jul 2019 21:42:32 +0000 (21:42 +0000)]
Merge "Improve type hints in export related classes"
jenkins-bot [Thu, 25 Jul 2019 21:26:41 +0000 (21:26 +0000)]
Merge "Add permission check for user is permitted to view the log type"
jenkins-bot [Thu, 25 Jul 2019 21:23:58 +0000 (21:23 +0000)]
Merge "Type hint against LinkTarget in WatchedItemStore"
Translation updater bot [Thu, 25 Jul 2019 20:39:50 +0000 (22:39 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I32ed9eb31204d18421f9d986d049feca65fbb62e
rxy [Fri, 31 May 2019 20:04:09 +0000 (20:04 +0000)]
Add permission check for user is permitted to view the log type
Note: formatter patch only
Note: cherry-picked I064f563cb here as well
Bug: T222038
Change-Id: I1c4e57a513e3a0e616b862a5b9d684f463ad9981
jenkins-bot [Thu, 25 Jul 2019 20:20:34 +0000 (20:20 +0000)]
Merge "resourceloader: Also clear store in debug mode to simplify mw.loader.store.init()"
jenkins-bot [Thu, 25 Jul 2019 16:45:52 +0000 (16:45 +0000)]
Merge "Update documentation for $wgAutopromote"
Timo Tijhof [Thu, 25 Jul 2019 16:37:46 +0000 (17:37 +0100)]
resourceloader: Also clear store in debug mode to simplify mw.loader.store.init()
This makes it consistent with the other two circumstances in which
mw.loader.store is disabled.
Also, it makes debug=true a more easily accessible means for users
to clear module storage, which can be useful at times (without requiring
console access).
Change-Id: I9c66815a2f6c60feef3e070cfe57c382a69cc752
Krinkle [Wed, 24 Jul 2019 19:29:56 +0000 (19:29 +0000)]
Make wfGetDB() return a MaintainableDBConnRef instance (take 2)
This enforces the DB_* role checks of DBConnRef in more places.
This is a re-submission of
335066505a3ea, which was reverted due to T228928.
Change-Id: I556627dc6486e6f6539d1d2dd5aa6f009eff341e
jenkins-bot [Thu, 25 Jul 2019 13:47:15 +0000 (13:47 +0000)]
Merge "Replace wfGetDB in ParserTestRunner"
jenkins-bot [Thu, 25 Jul 2019 13:36:09 +0000 (13:36 +0000)]
Merge "MimeAnalyzer: fix ZIP parsing failure"
jenkins-bot [Thu, 25 Jul 2019 10:41:07 +0000 (10:41 +0000)]
Merge "parser: inject a Logger into Parser instead of using wfDebug()"
Tim Starling [Thu, 25 Jul 2019 03:29:44 +0000 (13:29 +1000)]
MimeAnalyzer: fix ZIP parsing failure
unpack() actually returns an array with indexes starting from 1, not
zero, so unpack(...)[0] gives a notice and always returns null. It is
lucky that ZIPs normally have zero-length comments, so this would have
had little impact on file type detection aside from log spam.
Also, add a check to make sure the unpack() will not read beyond
the end of the file. Without this, unpack() could generate a warning.
The bug was introduced by me in
f12db3804882272794b.
Add tests. The test files were generated by appending an EOCDR signature
and some extra bytes to 1bit-png.png.
Bug: T223728
Change-Id: I6fab63102d1d8eea92cdcce5ab6d1eb747a0a890
jenkins-bot [Wed, 24 Jul 2019 22:41:53 +0000 (22:41 +0000)]
Merge "Do not block autopromote on partial blocks"
Thalia [Wed, 24 Jul 2019 22:21:06 +0000 (23:21 +0100)]
Update documentation for $wgAutopromote
Follow-up to
1ad840da68
Change-Id: I7c2dedf3824154c0c844f73a98e6824fe8ff141a
jenkins-bot [Wed, 24 Jul 2019 22:01:08 +0000 (22:01 +0000)]
Merge "Remove deprecated handling of array keys for $wgProxyList"
Gergő Tisza [Wed, 24 Jul 2019 21:52:24 +0000 (23:52 +0200)]
Replace wfGetDB in ParserTestRunner
After I0d7dacee3, wfGetDB returns a connection reference instead of
a real connection, which means it can't be passed to CloneDatabase
anymore, and testcase / test runner classes should avoid it.
Bug: T228928
Change-Id: I42be4214e33a4d4f8d53fafc925c8d708b4c0106
Thalia [Wed, 24 Jul 2019 17:17:36 +0000 (18:17 +0100)]
Remove deprecated handling of array keys for $wgProxyList
Change-Id: Ic9cc2a5585180ab57fd361342cbac8210b094a5c
Translation updater bot [Wed, 24 Jul 2019 20:02:28 +0000 (22:02 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I70c061d14d3768c28234257004f35299c80a3201
jenkins-bot [Wed, 24 Jul 2019 18:22:03 +0000 (18:22 +0000)]
Merge "Revert "Make wfGetDB() return a MaintainableDBConnRef instance""
Krinkle [Wed, 24 Jul 2019 18:07:18 +0000 (18:07 +0000)]
Revert "Make wfGetDB() return a MaintainableDBConnRef instance"
This reverts commit
335066505a3ea6121f3c5b5eae43b0c37ca6e2eb.
The standalone parser test runner, as used by Parsoid Jenkins builds,
is (indirectly) using wfGetDB in a way that isn't supported (changing
the selected database). This needs to be fixed, but we can give it
a few days.
Change-Id: I07ff422dd56d5700e570100747aa49b7764ec80f
jenkins-bot [Wed, 24 Jul 2019 18:02:51 +0000 (18:02 +0000)]
Merge "Add null to Parser::getTitle return doc"
Aaron Schulz [Sun, 7 Apr 2019 00:28:14 +0000 (17:28 -0700)]
Make wfGetDB() return a MaintainableDBConnRef instance
This enforces the DB_* role checks of DBConnRef in more places
Depends-on: I9328e709fe5d81099338a31deef24d34db22d784
Change-Id: I0d7dacee3ec4ef67dc0b0f6551ad046c74dc47dc
jenkins-bot [Wed, 24 Jul 2019 15:51:56 +0000 (15:51 +0000)]
Merge "installer: Stop offering MyISAM option for new installs and fix bogus method calls"
James D. Forrester [Wed, 24 Jul 2019 14:39:01 +0000 (07:39 -0700)]
.travis.yml: Don't allow failures for PHP 7.3 any more
Bug: T204884
Change-Id: I797855405cced7471ab40a7cf80980cf68c840ce
jenkins-bot [Wed, 24 Jul 2019 12:44:47 +0000 (12:44 +0000)]
Merge "Users with partial access to user rights should not be blocked"
jenkins-bot [Wed, 24 Jul 2019 12:13:53 +0000 (12:13 +0000)]
Merge "make XmlDumpwriter more resilient to blob store corruption"
jenkins-bot [Wed, 24 Jul 2019 10:47:00 +0000 (10:47 +0000)]
Merge "Drop newlines in LocalisationCache debug logs"
Antoine Musso [Wed, 24 Jul 2019 10:14:33 +0000 (12:14 +0200)]
Drop newlines in LocalisationCache debug logs
316d205115c migrated LocalisationCache from wfDebugLog() to the Logger
interface which no more requires the messages to be terminated with a
new line.
Change-Id: Ibe2f750e7ab16cf91801988cb726adb67f7cd9d2
jenkins-bot [Wed, 24 Jul 2019 10:10:23 +0000 (10:10 +0000)]
Merge "Validate sort order in Special:Search"
Ariel T. Glenn [Wed, 24 Jul 2019 05:56:41 +0000 (08:56 +0300)]
make XmlDumpwriter more resilient to blob store corruption
Loading content can also throw InvalidArgumentException when
the cluster address is an unknown cluster.
Bug: T228720
Change-Id: I313f9a5a27b21a33e90639abae3f505640c30e23
Sam Wilson [Wed, 24 Jul 2019 05:00:13 +0000 (13:00 +0800)]
Add null to Parser::getTitle return doc
Change-Id: I5086f636114cec83f0188d2309ea70aef27df13d
Gergő Tisza [Tue, 16 Jul 2019 13:28:28 +0000 (13:28 +0000)]
Fix and re-apply "RedirectSpecialPage: handle interwiki redirects"
This re-applies commit
41106688abbe6dfff61c5642924ced42af3f0d33
(thereby reverting commit
6c57748aeee6e4f2a197d64785102306fbd4a297)
and fixes it for local interwiki redirects by adding and using a
forcing parameter in Special:GoToInterwiki to treat local redirects
like external ones.
Bug: T227700
Change-Id: I4bc2ed998430fc2bac71baf850b8988fdb24c1ac
jenkins-bot [Wed, 24 Jul 2019 02:21:04 +0000 (02:21 +0000)]
Merge "Drop mediawiki.dic, useless and poorly updated"
jenkins-bot [Tue, 23 Jul 2019 21:13:46 +0000 (21:13 +0000)]
Merge "Don't double wrap rollback links"
jenkins-bot [Tue, 23 Jul 2019 20:34:00 +0000 (20:34 +0000)]
Merge "Add Hebrew aliases for some special pages"
jenkins-bot [Tue, 23 Jul 2019 19:13:11 +0000 (19:13 +0000)]
Merge "Drop wgPasswordSalt, deprecated since 1.24"
jdlrobson [Tue, 23 Jul 2019 19:07:47 +0000 (12:07 -0700)]
Don't double wrap rollback links
Bug: T228766
Change-Id: Iaca54e1ceefc73815fe3d9898ca490b74d11dac6
jenkins-bot [Tue, 23 Jul 2019 19:00:17 +0000 (19:00 +0000)]
Merge "objectcache: Use variadic signature for makeKey()"
Timo Tijhof [Sat, 20 Jul 2019 16:49:06 +0000 (17:49 +0100)]
objectcache: Use variadic signature for makeKey()
This should help fix the following issues that various repos
are getting from Phan as of late:
> Call with 5 arg(s) to \BagOStuff::makeKey() which only takes 2 arg(s)
> defined at ../../includes/libs/objectcache/BagOStuff.php:456
> <source="PhanParamTooMany"/>
Bug: T228563
Depends-On: I5cfba063821101325a5a7359e6b8ad71a0fb1b2f
Depends-On: Ifa5b96735376f2fbe3680799f960616ba8d357ff
Change-Id: Ic9df7f3ad7f356c7cbdfe1edfbe35821b931dda6
Erik Bernhardson [Mon, 22 Jul 2019 19:10:54 +0000 (12:10 -0700)]
Validate sort order in Special:Search
Providing an invalid sort order to Special:Search could trigger an
exception from the search engine when trying to apply it. Validate the
sort order, much like API classes do, and let the user know that the
sort they requested could not be applied.
We also have a unreported error for invalid profile requested, so
added that warning to the display while here.
Bug: T228171
Change-Id: I79079eea8c03a90b5b65f1dad11c99e514de00e1
jenkins-bot [Tue, 23 Jul 2019 17:13:45 +0000 (17:13 +0000)]
Merge "Make XmlDumpwriter resilient to blob store corruption."
jenkins-bot [Tue, 23 Jul 2019 16:23:02 +0000 (16:23 +0000)]
Merge "Avoid the use of silence operator (@) and use AtEase methods"
jenkins-bot [Tue, 23 Jul 2019 15:50:13 +0000 (15:50 +0000)]
Merge "filerepo: make ForeignApiRepo::httpGetCached() use "pcGroup""
jenkins-bot [Tue, 23 Jul 2019 15:15:48 +0000 (15:15 +0000)]
Merge "filebackend: avoid use of LoadBalancer::newMainLB() in LockManagerGroup"
jenkins-bot [Tue, 23 Jul 2019 15:02:47 +0000 (15:02 +0000)]
Merge "Replace wfWiki() usage with WikiMap in some additional places"
Bartosz Dziewoński [Tue, 23 Jul 2019 12:57:38 +0000 (14:57 +0200)]
Add release note for custom OOUI themes using OOUIThemePaths (T100896)
Change-Id: I98f370310d93fc178e0baf55798808fa4ece2f92
daniel [Tue, 23 Jul 2019 11:23:41 +0000 (13:23 +0200)]
Make XmlDumpwriter resilient to blob store corruption.
In the WMF databases, we have several revisions for which we cannot
load the content. They typically (but not necessarily) have
content_address = "tt:0" and content_sha1 = "" and rev_sha1 = ""
and content_size = 0 and rev_len = 0.
This patch makes sure we can still generate dumps in the presence of
such revisions.
Bug: T228720
Change-Id: Iaadad44eb5b5fe5a4f2e60da406ffc11f39c735b
jenkins-bot [Tue, 23 Jul 2019 11:01:01 +0000 (11:01 +0000)]
Merge "Update LanguageTrTest::testDottedAndDotlessI for PHP 7.3"
jenkins-bot [Tue, 23 Jul 2019 10:54:30 +0000 (10:54 +0000)]
Merge "Update OOUI to v0.33.4"
Derick Alangi [Wed, 12 Jun 2019 12:47:06 +0000 (13:47 +0100)]
Avoid the use of silence operator (@) and use AtEase methods
Bug: T26159
Change-Id: I973cc607fd909d47faf2773a02835af83bbc301f
Santhosh Thottingal [Tue, 23 Jul 2019 06:50:52 +0000 (12:20 +0530)]
Update LanguageTrTest::testDottedAndDotlessI for PHP 7.3
PHP 7.3+ uses Unicode CaseFolding.txt for case mappings. For Turkic
languages(tr,az) the dotted i is given as a special case and we need
to implement it specifically for tr and az.
Updated the documentation and refactored the lcfirst and ucfirst methods
to use arrays containing the above mentioned special cases.
Bug: T207100
Change-Id: I317f2ca66b0adeaa79bc0f9e3dea5edfcd5e4693
Translation updater bot [Tue, 23 Jul 2019 06:28:43 +0000 (08:28 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Iaa4395494b2a07ab4107c5465fb09c7ba028cd0c
James D. Forrester [Tue, 23 Jul 2019 03:30:58 +0000 (20:30 -0700)]
Update OOUI to v0.33.4
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.33.4
Bug: T171865
Bug: T224070
Depends-On: Iec2d70793459492c3cebaa735753e0afa542e7c4
Change-Id: Iec2d70793459492c3cebaa735753e0afa542e7ca
jenkins-bot [Mon, 22 Jul 2019 22:11:09 +0000 (22:11 +0000)]
Merge "Add ISearchResultSet"
jenkins-bot [Mon, 22 Jul 2019 21:45:41 +0000 (21:45 +0000)]
Merge "ChangesList: Add $groups parameter to FetchChangesList hook"
jdlrobson [Fri, 19 Jul 2019 14:46:57 +0000 (07:46 -0700)]
ChangesList: Add $groups parameter to FetchChangesList hook
This parameter is needed for consumers trying to return a $list object.
Bug: T228280
Change-Id: Ib68ff8fa782ac12479ef02247cdf78e405b64bad
jenkins-bot [Mon, 22 Jul 2019 20:58:00 +0000 (20:58 +0000)]
Merge "Fix bad method call to \MediaWiki\Widget\Search\SearchResultWidget::render"
jenkins-bot [Mon, 22 Jul 2019 20:57:44 +0000 (20:57 +0000)]
Merge "Deprecate SearchResultSet::free"
Translation updater bot [Mon, 22 Jul 2019 20:13:38 +0000 (22:13 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I08f1713b6e61980009fc99d50ccdf2f874dc1230
James D. Forrester [Mon, 22 Jul 2019 19:33:32 +0000 (12:33 -0700)]
Drop mediawiki.dic, useless and poorly updated
Change-Id: Ie48eab4e989013e425d39dd92b9545079d47bb0c
David Causse [Mon, 22 Jul 2019 15:28:48 +0000 (17:28 +0200)]
Add ISearchResultSet
Bug: T228626
Change-Id: I3306bf6107c97dd58adf578fd965bd11a422627d
Guycn2 [Sat, 19 May 2018 23:34:53 +0000 (23:34 +0000)]
Add Hebrew aliases for some special pages
I've used the same translation as the pages' titles (except for "GoToInterwiki" which doesn't have one).
Change-Id: Ibf7137636f351a31e86a4621a644b9c41cc3a73e
David Causse [Mon, 22 Jul 2019 13:25:03 +0000 (15:25 +0200)]
Fix bad method call to \MediaWiki\Widget\Search\SearchResultWidget::render
Change-Id: I6b3a65ba62a9686bdc65110cba9d61362e584051
David Causse [Mon, 22 Jul 2019 10:08:32 +0000 (12:08 +0200)]
Deprecate SearchResultSet::free
Was only called by SpecialSearch, according to IResultWrapper::free()
this method is rarely worth being called. Therefor it does not seem wise
to expose it in the upcoming interface defining a search result set.
Bug: T228626
Change-Id: I12d41a488025eb2d6dd543c9fbdc1c803c840316
jenkins-bot [Mon, 22 Jul 2019 14:49:03 +0000 (14:49 +0000)]
Merge "changes: Usage of 'noudp' & 'pleasedontudp' no longer exist"
Derick Alangi [Thu, 18 Jul 2019 10:51:08 +0000 (11:51 +0100)]
changes: Usage of 'noudp' & 'pleasedontudp' no longer exist
Since no usage exist and this was deprecated in 1.31, should it
be removed?
Now I think with the use of Phan and having $send type hinted to
a bool, if a string is used, phan will catch that? :)
Usage
=====
https://codesearch.wmflabs.org/search/?q=(%27noudp%27%7C%27pleasedontudp%27)&i=nope&files=&repos=
Change-Id: Id0482e69e2e2b1cdf0a9ece230e04323bf51324f
Ariel T. Glenn [Mon, 22 Jul 2019 07:28:51 +0000 (10:28 +0300)]
don't load revision text content unless requested to
Bug: T228614
Change-Id: Idef4d9684560110a16c6a7c074402c5a5a6e59db
jenkins-bot [Sun, 21 Jul 2019 19:41:24 +0000 (19:41 +0000)]
Merge "Do not hardcode square brackets in "rollback link""
James D. Forrester [Fri, 12 Jul 2019 23:44:38 +0000 (16:44 -0700)]
Drop wgPasswordSalt, deprecated since 1.24
Depends-On: Ic9952a1bd8563f218c3c581d4b206ebd6c6c9c44
Change-Id: I8b1d43aba62859645221caf5ff340903e4d61787
James D. Forrester [Sun, 21 Jul 2019 18:59:53 +0000 (11:59 -0700)]
Follow-up
ffd802a386: Actually disable legacy JS globals
Bug: T72470
Change-Id: I2703420afd260c1c9d0cdc17baceed12dc28f758
jenkins-bot [Sun, 21 Jul 2019 18:11:12 +0000 (18:11 +0000)]
Merge "Exclude redirects from Special:Fewestrevisions"
Derick Alangi [Sun, 21 Jul 2019 14:54:52 +0000 (15:54 +0100)]
Avoid usage of deprecated Revision::* constants
Change-Id: I2d06bbacef88573f286da25994a3ad434ed90e9c
Derick Alangi [Sun, 21 Jul 2019 14:32:13 +0000 (15:32 +0100)]
Avoid usage of deprecated Revision::* constants
Change-Id: Ibb55d5a01f997f9c79bcf2f5e09d4f02d22152d2
Aaron Schulz [Tue, 16 Jul 2019 04:06:42 +0000 (21:06 -0700)]
filerepo: make ForeignApiRepo::httpGetCached() use "pcGroup"
Given the item size, it is best to keep the cache limit small
Change-Id: Icf57a5e54046d4909535f772f1556452ccb122df
Derick Alangi [Sun, 21 Jul 2019 14:18:51 +0000 (15:18 +0100)]
api: Avoid usage of deprecated Revision::FOR_THIS_USER constant
Change-Id: I48b302ba3ea5762e2b576e972cf85d57cd73fb15
Derick Alangi [Sun, 21 Jul 2019 14:15:46 +0000 (15:15 +0100)]
action: Avoid use of deprecated Revision::* constants, use RevisionRecord
Change-Id: I09e3182cd83977d143ca7b34b791ea2cd0df0ef8
Derick Alangi [Sun, 21 Jul 2019 13:18:14 +0000 (14:18 +0100)]
Avoid usage of deprecated Revision::* constants, use RevisionRecord
Change-Id: I872fc89e5c02dd6a3ae9cd7e76640b95dc33f514
jenkins-bot [Sun, 21 Jul 2019 12:22:09 +0000 (12:22 +0000)]
Merge "maintenance: Avoid usage of deprecated Revision::* constants"
Derick Alangi [Sat, 20 Jul 2019 08:47:52 +0000 (09:47 +0100)]
maintenance: Avoid usage of deprecated Revision::* constants
Update deprecated Revision::* constants to use RevisionRecord::*
equivalents.
Change-Id: Icae1ebb088e4efadbc7c2806127a2073d337fa05
Aaron Schulz [Sat, 29 Jun 2019 07:58:02 +0000 (00:58 -0700)]
installer: Stop offering MyISAM option for new installs and fix bogus method calls
The methods were renamed in 2010 (r68908,
c4100fb83b5b12bd).
Change-Id: I076ec8d9c11f5bd33cb0ad19e5be8e239401b9c6
jenkins-bot [Sat, 20 Jul 2019 23:53:30 +0000 (23:53 +0000)]
Merge "objectcache: reorganize WANObjectCache fields and avoid exposing internal constants"
jenkins-bot [Sat, 20 Jul 2019 23:25:47 +0000 (23:25 +0000)]
Merge "MessageCache: Fix isMainCacheable() logic for non-content languages"
Aaron Schulz [Mon, 15 Jul 2019 21:57:01 +0000 (14:57 -0700)]
objectcache: reorganize WANObjectCache fields and avoid exposing internal constants
Change-Id: I95771fc8d032939e71adba3a416894004ea0847d
jenkins-bot [Sat, 20 Jul 2019 21:31:32 +0000 (21:31 +0000)]
Merge "resourceloader: Move FilePath test to /tests/phpunit/unit"
Timo Tijhof [Fri, 19 Jul 2019 22:39:11 +0000 (23:39 +0100)]
resourceloader: Move FilePath test to /tests/phpunit/unit
Pure value object. No external dependencies.
Change-Id: If4120ca302c2fab2a41880c32e164d36566ed9de
jenkins-bot [Sat, 20 Jul 2019 06:20:45 +0000 (06:20 +0000)]
Merge "installer: Add a defined check to overrideConfig method"
jenkins-bot [Sat, 20 Jul 2019 06:17:12 +0000 (06:17 +0000)]
Merge "Increase test coverage for BlockManager class"
Roan Kattouw [Fri, 19 Jul 2019 23:51:01 +0000 (16:51 -0700)]
MessageCache: Fix isMainCacheable() logic for non-content languages
The way isMainCacheable() was used, it always returned false in
non-content languages, because it would try to find strings like
'hidetoc/fr' in the array of message keys (which contains strings like
'hidetoc').
The consequence of this was that MessageCache would check the database
for a MediaWiki:hidetoc/fr page even if it already knew that that page
didn't exist. This is a substantial performance hit when requesting lots
of messages, like when building version hashes for ResourceLoader's
startup module.
Follows-up
4fc5ba8bf83102b02.
Bug: T228555
Change-Id: I20433175ca919acc1c995f4a9cd50ca53afcdd02
jenkins-bot [Fri, 19 Jul 2019 23:13:58 +0000 (23:13 +0000)]
Merge "resourceloader: Complete test coverage for FilePath"
Timo Tijhof [Fri, 19 Jul 2019 22:36:06 +0000 (23:36 +0100)]
resourceloader: Complete test coverage for FilePath
The 'getLocalBasePath' and 'getRemoteBasePath' methods were not
yet covered.
Change-Id: If2eacca3a908048ec62b357e14e4e2322363e296
jenkins-bot [Fri, 19 Jul 2019 22:34:12 +0000 (22:34 +0000)]
Merge "API: Fix 'user_id' field of ApiCSPReport"
jenkins-bot [Fri, 19 Jul 2019 22:33:00 +0000 (22:33 +0000)]
Merge "API: Add test case for ApiCSPReportTest"
Timo Tijhof [Fri, 19 Jul 2019 21:34:34 +0000 (22:34 +0100)]
API: Fix 'user_id' field of ApiCSPReport
Was accidentally turned into an always-true boolean in
5f343617,
due to confusion with JavaScript's default '||' operator.
Change-Id: I24071e22f8bb7a296ae138303f63acdb8ea4950a
Timo Tijhof [Fri, 19 Jul 2019 21:33:31 +0000 (22:33 +0100)]
API: Add test case for ApiCSPReportTest
Covers the basic functioning of the class, as well as the specific
behaviours introduced or changed by
5f34361759 and
0ca1b8a0e621c9.
Also includes a (bad) expectation for 'user_id' (bool instead of string),
which is a bug caused by
5f34361759 that the next commit will fix.
Change-Id: I2c57c813b8a31e51a61778951227ccbd1217a547
jenkins-bot [Fri, 19 Jul 2019 21:53:46 +0000 (21:53 +0000)]
Merge "DevelopmentSettings: Disable legacy javascript globals in CI and for devs"
James D. Forrester [Fri, 19 Jul 2019 20:53:57 +0000 (13:53 -0700)]
DevelopmentSettings: Disable legacy javascript globals in CI and for devs
Bug: T72470
Change-Id: Iedd3a9c8e541bc4cc657753e6ae3389f0393ed64
James D. Forrester [Tue, 2 Jul 2019 21:58:36 +0000 (14:58 -0700)]
Drop UploadBase:: and UploadFromChunks::stashFileGetKey() and stashSession(), deprecated in 1.28
Change-Id: I2411753a24092a5c37434b095e594831ecff04e1