From: Chad Horohoe <demon@users.mediawiki.org>
Date: Mon, 9 Jun 2008 13:03:58 +0000 (+0000)
Subject: Bug 10080 - Finally fixed. No longer mis-detects an individual IP as blocked when... 
X-Git-Tag: 1.31.0-rc.0~47105
X-Git-Url: http://git.cyclocoop.org/%27.%28%24current%20%3E%202?a=commitdiff_plain;h=7ad99d6d8ce3815bcb657e902a404030466f950f;p=lhc%2Fweb%2Fwiklou.git

Bug 10080 - Finally fixed. No longer mis-detects an individual IP as blocked when the range is. Also, introduced new msg called ipb_tweak_block (per request of Siebrand) as opposed to repurposing ipb_already_blocked.
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 3b8dca3984..eb850c0156 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -342,6 +342,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * (bug 14385) "Move subpages" option no longer tries to move to invalid titles
 * (bug 14386) Fix subpage namespace oddity when moving a talk page
 * (bug 11771) Signup form now not shown if in read-only mode.
+* (bug 10080) Users can now modify an existing block without unblocking first.
 * (bug 12859) $wgRateLimitsExcludedGroups has been deprecated in favor of
   $wgGroupPermissions[]['noratelimit']. 
 * (Bug 13828) Split parameter $1 of MediaWiki:Missingarticle into $1 (=title)
diff --git a/includes/SpecialBlockip.php b/includes/SpecialBlockip.php
index 5ea25ca46a..ec1fdd7886 100644
--- a/includes/SpecialBlockip.php
+++ b/includes/SpecialBlockip.php
@@ -32,8 +32,10 @@ function wfSpecialBlockip( $par ) {
 	} else if ( $wgRequest->wasPosted() && 'submit' == $action &&
 		$wgUser->matchEditToken( $wgRequest->getVal( 'wpEditToken' ) ) ) {
 		$ipb->doSubmit();
+	} else if ( $ipb->AlreadyBlocked ) {
+		$ipb->showForm( wfMsg('ipb_tweak_block', $ipb->BlockAddress ) );
 	} else {
-		$ipb->showForm( '' );
+		$ipb->showForm('');
 	}
 }
 
@@ -47,10 +49,32 @@ class IPBlockForm {
 #	var $BlockEmail;
 
 	function IPBlockForm( $par ) {
-		global $wgRequest, $wgUser;
+		global $wgRequest, $wgUser, $wgLang;
 
 		$this->BlockAddress = $wgRequest->getVal( 'wpBlockAddress', $wgRequest->getVal( 'ip', $par ) );
 		$this->BlockAddress = strtr( $this->BlockAddress, '_', ' ' );
+		$this->AlreadyBlocked = false;
+
+		if( $this->BlockAddress && !$wgRequest->wasPosted() ){
+			$this->mBlock = new Block();
+			if( $this->mBlock->load($this->BlockAddress) && $this->BlockAddress == $this->mBlock->mAddress ) {
+				$this->AlreadyBlocked = true;
+				$this->BlockReason = wfMsgForContent( 'ipb_modifying_block' );
+				$this->BlockReasonList = $wgRequest->getText( 'wpBlockReasonList' );
+				$this->BlockExpiry = wfMsg('ipbotheroption');
+				$this->BlockOther = $wgLang->timeanddate( $this->mBlock->mExpiry );
+				$this->BlockAnonOnly = $wgRequest->getBool( 'wpAnonOnly', true );
+				$this->BlockCreateAccount = $wgRequest->getBool( 'wpCreateAccount', true );
+				$this->BlockEnableAutoblock = $wgRequest->getBool( 'wpEnableAutoblock', true );
+				$this->BlockEmail = $wgRequest->getBool( 'wpEmailBan', false );
+				$this->BlockEmail = $this->mBlock->mBlockEmail;
+				$this->BlockWatchUser = $wgRequest->getBool( 'wpWatchUser', false );
+				# Re-check user's rights to hide names, very serious, defaults to 0
+				$this->BlockHideName = ( $this->mBlock->mHideName && $wgUser->isAllowed( 'hideuser' ) ) ? 1 : 0;
+				return true;
+			}
+		}
+		
 		$this->BlockReason = $wgRequest->getText( 'wpBlockReason' );
 		$this->BlockReasonList = $wgRequest->getText( 'wpBlockReasonList' );
 		$this->BlockExpiry = $wgRequest->getVal( 'wpBlockExpiry', wfMsg('ipbotheroption') );
@@ -69,7 +93,7 @@ class IPBlockForm {
 	}
 
 	function showForm( $err ) {
-		global $wgOut, $wgUser, $wgSysopUserBans;
+		global $wgOut, $wgUser, $wgSysopUserBans, $wgRequest;
 
 		$wgOut->setPagetitle( wfMsg( 'blockip' ) );
 		$wgOut->addWikiMsg( 'blockiptext' );
@@ -86,8 +110,10 @@ class IPBlockForm {
 
 		$titleObj = SpecialPage::getTitleFor( 'Blockip' );
 
-		if ( "" != $err ) {
+		if ( $wgRequest->wasPosted() ) {
 			$wgOut->setSubtitle( wfMsgHtml( 'formerror' ) );
+		}
+		if ( "" != $err ) {
 			$wgOut->addHTML( Xml::tags( 'p', array( 'class' => 'error' ), $err ) );
 		}
 
@@ -363,7 +389,10 @@ class IPBlockForm {
 		if ( wfRunHooks('BlockIp', array(&$block, &$wgUser)) ) {
 
 			if ( !$block->insert() ) {
-				return array('ipb_already_blocked', htmlspecialchars($this->BlockAddress));
+				// Block already exists. Silently delete the existing block and insert it again
+				$oldblock = Block::newFromDB( $this->BlockAddress );
+				$oldblock->delete();
+				$block->insert();
 			}
 
 			wfRunHooks('BlockIpComplete', array($block, $wgUser));
diff --git a/languages/messages/MessagesEn.php b/languages/messages/MessagesEn.php
index 156cd2e3bd..85b61762cc 100644
--- a/languages/messages/MessagesEn.php
+++ b/languages/messages/MessagesEn.php
@@ -2363,6 +2363,9 @@ See the [[Special:Ipblocklist|IP block list]] for the list of currently operatio
 'ipb_expiry_invalid'          => 'Expiry time invalid.',
 'ipb_expiry_temp'             => 'Hidden username blocks should be permanent.',
 'ipb_already_blocked'         => '"$1" is already blocked',
+'ipb_modifying_block'         => 'Modifying existing block:',
+'ipb_tweak_block'             => 'Caution: This user ($1) is already blocked. 
+You can use this form to change the block settings.',
 'ipb_cant_unblock'            => 'Error: Block ID $1 not found. It may have been unblocked already.',
 'ipb_blocked_as_range'        => 'Error: The IP $1 is not blocked directly and cannot be unblocked.
 It is, however, blocked as part of the range $2, which can be unblocked.',
diff --git a/maintenance/language/messages.inc b/maintenance/language/messages.inc
index dd83e4193d..2b30ddd5da 100644
--- a/maintenance/language/messages.inc
+++ b/maintenance/language/messages.inc
@@ -1618,6 +1618,7 @@ $wgMessageStructure = array(
 		'ipb_expiry_invalid',
 		'ipb_expiry_temp',
 		'ipb_already_blocked',
+		'ipb_tweak_block',
 		'ipb_modifying_block',
 		'ipb_cant_unblock',
 		'ipb_blocked_as_range',