From: Roan Kattouw <roan.kattouw@gmail.com>
Date: Tue, 21 Aug 2018 01:54:39 +0000 (-0700)
Subject: ChangeTags: Fix double escaping of tag descriptions
X-Git-Tag: 1.34.0-rc.0~4357^2
X-Git-Url: http://git.cyclocoop.org/%27.%28%24current%20%3E%202?a=commitdiff_plain;h=0c37a16e6013dd774df8644748bd94b38b85347c;p=lhc%2Fweb%2Fwiklou.git

ChangeTags: Fix double escaping of tag descriptions

truncateTagDescription() was escaping its return value for HTML, even
though it had just produced plain text, and all similar functions
return plain text as well.

Bug: T192509
Change-Id: Ieaa631ef19c235121af9d8e09f2674f54fa3c25a
---

diff --git a/includes/changetags/ChangeTags.php b/includes/changetags/ChangeTags.php
index b5bf488acb..9a015f4503 100644
--- a/includes/changetags/ChangeTags.php
+++ b/includes/changetags/ChangeTags.php
@@ -201,9 +201,8 @@ class ChangeTags {
 		}
 
 		$taglessDesc = Sanitizer::stripAllTags( $originalDesc->parse() );
-		$escapedDesc = Sanitizer::escapeHtmlAllowEntities( $taglessDesc );
 
-		return $context->getLanguage()->truncateForVisual( $escapedDesc, $length );
+		return $context->getLanguage()->truncateForVisual( $taglessDesc, $length );
 	}
 
 	/**