From: MtDu <justin.d128@gmail.com>
Date: Mon, 28 Nov 2016 23:46:44 +0000 (-0600)
Subject: List grant codenames next to grants on Special:ListGrants
X-Git-Tag: 1.31.0-rc.0~4737^2
X-Git-Url: http://git.cyclocoop.org/%27%40script%40/%28?a=commitdiff_plain;h=9e2ce38a03595965a181421f9ce5f63456f36061;p=lhc%2Fweb%2Fwiklou.git

List grant codenames next to grants on Special:ListGrants

Bug: T145351
Change-Id: Ia07de6269fa6192071aaea5d750362685389001c
---

diff --git a/includes/specials/SpecialListgrants.php b/includes/specials/SpecialListgrants.php
index 39c8ae8a93..2c92410cbc 100644
--- a/includes/specials/SpecialListgrants.php
+++ b/includes/specials/SpecialListgrants.php
@@ -71,8 +71,14 @@ class SpecialListGrants extends SpecialPage {
 
 			$id = \Sanitizer::escapeId( $grant );
 			$out->addHTML( \Html::rawElement( 'tr', [ 'id' => $id ],
-				"<td>" . $this->msg( "grant-$grant" )->escaped() . "</td>" .
-				"<td>" . $grantCellHtml . '</td>'
+				"<td>" .
+				$this->msg(
+					"listgrants-grant-display",
+					\User::getGrantName( $grant ),
+					"<span class='mw-listgrants-grant-name'>" . $id . "</span>"
+				)->parse() .
+				"</td>" .
+				"<td>" . $grantCellHtml . "</td>"
 			) );
 		}
 
diff --git a/includes/user/User.php b/includes/user/User.php
index 82d8806f75..b6a64b0412 100644
--- a/includes/user/User.php
+++ b/includes/user/User.php
@@ -5075,6 +5075,19 @@ class User implements IDBAccessObject {
 		return $msg->isBlank() ? $right : $msg->text();
 	}
 
+	/**
+	 * Get the name of a given grant
+	 *
+	 * @since 1.29
+	 * @param string $grant Grant to query
+	 * @return string Localized name of the grant
+	 */
+	public static function getGrantName( $grant ) {
+		$key = "grant-$grant";
+		$msg = wfMessage( $key );
+		return $msg->isDisabled() ? $grant : $msg->text();
+	}
+
 	/**
 	 * Make a new-style password hash
 	 *
diff --git a/languages/i18n/en.json b/languages/i18n/en.json
index 9aa0f4605f..0b85a4b877 100644
--- a/languages/i18n/en.json
+++ b/languages/i18n/en.json
@@ -2023,6 +2023,7 @@
 	"listgrants-summary": "The following is a list of grants with their associated access to user rights. Users can authorize applications to use their account, but with limited permissions based on the grants the user gave to the application. An application acting on behalf of a user cannot actually use rights that the user does not have however.\nThere may be [[{{MediaWiki:Listgrouprights-helppage}}|additional information]] about individual rights.",
 	"listgrants-grant": "Grant",
 	"listgrants-rights": "Rights",
+	"listgrants-grant-display": "$1 <code>($2)</code>",
 	"trackingcategories": "Tracking categories",
 	"trackingcategories-summary": "This page lists tracking categories which are automatically populated by the MediaWiki software. Their names can be changed by altering the relevant system messages in the {{ns:8}} namespace.",
 	"trackingcategories-msg": "Tracking category",
diff --git a/languages/i18n/qqq.json b/languages/i18n/qqq.json
index 7327012152..9a1cd6569b 100644
--- a/languages/i18n/qqq.json
+++ b/languages/i18n/qqq.json
@@ -2207,6 +2207,7 @@
 	"listgrants-summary": "Explanatory text shown at the top of the grant/rights mapping table.\n\nRefers to {{msg-mw|Listgrouprights-helppage}}.",
 	"listgrants-grant": "Used as table header for the grant/rights mapping table.\n{{Identical|Grant}}",
 	"listgrants-rights": "Used as table header for the grant/rights mapping table.\n{{Identical|Right}}",
+	"listgrants-grant-display": "{{optional}}\nUsed to display the code name of a grant next to the grant. Parameters:\n* $1 - the text from the \"grant-...\" messages, i.e. {{msg-mw|Grant-highvolume}}\n* $2 - the codename of this grant",
 	"trackingcategories": "[[Special:TrackingCategories]] page implementing list of Tracking categories [[mw:Special:MyLanguage/Help:Tracking categories|tracking category]].\n{{Identical|Tracking category}}",
 	"trackingcategories-summary": "Description for [[Special:TrackingCategories]] page [[mw:Help:Tracking categories|tracking category]]",
 	"trackingcategories-msg": "Header for the message column of the table on [[Special:TrackingCategories]]. This column lists the mediawiki message that controls the tracking category in question.\n{{Identical|Tracking category}}",