From: Matěj Suchánek <matejsuchanek97@gmail.com>
Date: Sun, 3 Feb 2019 12:17:04 +0000 (+0100)
Subject: Prevent undesired toggling on Special:NewPages
X-Git-Tag: 1.34.0-rc.0~2949^2
X-Git-Url: http://git.cyclocoop.org/%27%2C%20%20%20quote_amp%28%24url%29%2C%20%20%20%27?a=commitdiff_plain;h=aa9ad966ebd60b9940466839e8e94b1c65d12df3;p=lhc%2Fweb%2Fwiklou.git

Prevent undesired toggling on Special:NewPages

Bug: T211549
Change-Id: I09928674c66a6359a417a221049259cb318dd00a
---

diff --git a/includes/specials/SpecialNewpages.php b/includes/specials/SpecialNewpages.php
index 8051b0b4e4..2bbc0bf486 100644
--- a/includes/specials/SpecialNewpages.php
+++ b/includes/specials/SpecialNewpages.php
@@ -192,9 +192,12 @@ class SpecialNewpages extends IncludableSpecialPage {
 		// wfArrayToCgi(), called from LinkRenderer/Title, will not output null and false values
 		// to the URL, which would omit some options (T158504). Fix it by explicitly setting them
 		// to 0 or 1.
-		$changed = array_map( function ( $value ) {
-			return $value ? '1' : '0';
-		}, $changed );
+		// Also do this only for boolean options, not eg. namespace or tagfilter
+		foreach ( $changed as $key => $value ) {
+			if ( array_key_exists( $key, $filters ) ) {
+				$changed[$key] = $changed[$key] ? '1' : '0';
+			}
+		}
 
 		$self = $this->getPageTitle();
 		$linkRenderer = $this->getLinkRenderer();