From: Mukunda Modell <mmodell@wikimedia.org>
Date: Fri, 19 Oct 2018 18:45:54 +0000 (-0500)
Subject: eval.php: write error messages to stderr
X-Git-Tag: 1.34.0-rc.0~3191
X-Git-Url: http://git.cyclocoop.org/%27%20.%20%24url%20.%20%27?a=commitdiff_plain;h=5f4748f07fc91e5f1681e94460ce7480e4d97530;p=lhc%2Fweb%2Fwiklou.git

eval.php: write error messages to stderr

Error messages should go to stderr not stdout.

Bug: T121597
Change-Id: Ibde26059982d1e621a104694343682a2032ac844
---

diff --git a/maintenance/eval.php b/maintenance/eval.php
index 40d29ef87c..f0d7fbf87a 100644
--- a/maintenance/eval.php
+++ b/maintenance/eval.php
@@ -77,8 +77,8 @@ while ( ( $__line = Maintenance::readconsole() ) !== false ) {
 	try {
 		$__val = eval( $__line . ";" );
 	} catch ( Exception $__e ) {
-		echo "Caught exception " . get_class( $__e ) .
-			": {$__e->getMessage()}\n" . $__e->getTraceAsString() . "\n";
+		fwrite( STDERR, "Caught exception " . get_class( $__e ) .
+			": {$__e->getMessage()}\n" . $__e->getTraceAsString() . "\n" );
 		continue;
 	}
 	if ( wfIsHHVM() || is_null( $__val ) ) {