From ef73a925807679e918f3ee5f05f0048566fce218 Mon Sep 17 00:00:00 2001
From: Reedy <reedy@wikimedia.org>
Date: Sat, 7 Apr 2012 20:19:28 +0100
Subject: [PATCH] Fix assignment in conditional

Change-Id: I11e280daa4df6623a03892a59f9f7236dd4c98af
---
 includes/specials/SpecialVersion.php | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/includes/specials/SpecialVersion.php b/includes/specials/SpecialVersion.php
index 777af416fa..2e2b003aa6 100644
--- a/includes/specials/SpecialVersion.php
+++ b/includes/specials/SpecialVersion.php
@@ -194,12 +194,16 @@ class SpecialVersion extends SpecialPage {
 		global $wgVersion;
 		wfProfileIn( __METHOD__ );
 
-		if( $gitVersion = self::getVersionLinkedGit() ) {
+		$gitVersion = self::getVersionLinkedGit();
+		if( $gitVersion ) {
 			$v = $gitVersion;
-		} elseif( $svnVersion = self::getVersionLinkedSvn() ) {
-			$v = $svnVersion;
 		} else {
-			$v = $wgVersion; // fallback
+			$svnVersion = self::getVersionLinkedSvn();
+			if( $svnVersion ) {
+				$v = $svnVersion;
+			} else {
+				$v = $wgVersion; // fallback
+			}
 		}
 
 		wfProfileOut( __METHOD__ );
@@ -207,7 +211,7 @@ class SpecialVersion extends SpecialPage {
 	}
 
 	/**
-	 * @return string wgVersion + a link to subversion revision of svn BASE 
+	 * @return string wgVersion + a link to subversion revision of svn BASE
 	 */
 	private static function getVersionLinkedSvn() {
 		global $wgVersion, $IP;
-- 
2.20.1