From d8b8075cc0dac4e2375890bc843c155b961755e6 Mon Sep 17 00:00:00 2001 From: Platonides Date: Fri, 10 Sep 2010 20:31:44 +0000 Subject: [PATCH] (Bug 25138) ApiUndelete begins a transaction, but does not commit. The UI doesn't use a transaction either, although it seems appropiate. The begin() should be moved into PageArchive::undelete() --- includes/api/ApiUndelete.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/includes/api/ApiUndelete.php b/includes/api/ApiUndelete.php index d081d0d75f..83c3fbe59a 100644 --- a/includes/api/ApiUndelete.php +++ b/includes/api/ApiUndelete.php @@ -69,8 +69,6 @@ class ApiUndelete extends ApiBase { } $pa = new PageArchive( $titleObj ); - $dbw = wfGetDB( DB_MASTER ); - $dbw->begin(); $retval = $pa->undelete( ( isset( $params['timestamps'] ) ? $params['timestamps'] : array() ), $params['reason'] ); if ( !is_array( $retval ) ) { $this->dieUsageMsg( array( 'cannotundelete' ) ); -- 2.20.1