From cf850c1fc82cbbdbb5379efc5851e14b5509c7a6 Mon Sep 17 00:00:00 2001 From: umherirrender Date: Sun, 17 Mar 2013 15:57:31 +0100 Subject: [PATCH] Remove error suppression in Exif::isRational preg_match throws warning, when getting a array as input, but there is a is_array check, so no need for error suppression Change-Id: Ie7f180f45c04e8e396186cd6a5a9e40e2c94a80a --- includes/media/Exif.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/media/Exif.php b/includes/media/Exif.php index 20b84d5515..17671808a9 100644 --- a/includes/media/Exif.php +++ b/includes/media/Exif.php @@ -677,7 +677,7 @@ class Exif { */ private function isRational( $in ) { $m = array(); - if ( !is_array( $in ) && @preg_match( '/^(\d+)\/(\d+[1-9]|[1-9]\d*)$/', $in, $m ) ) { # Avoid division by zero + if ( !is_array( $in ) && preg_match( '/^(\d+)\/(\d+[1-9]|[1-9]\d*)$/', $in, $m ) ) { # Avoid division by zero return $this->isLong( $m[1] ) && $this->isLong( $m[2] ); } else { $this->debug( $in, __FUNCTION__, 'fed a non-fraction value' ); -- 2.20.1