From 9a16c8035ad7d437d325f2e719a2e3e7340af1f8 Mon Sep 17 00:00:00 2001 From: River Tarnell Date: Fri, 29 Jul 2005 05:51:25 +0000 Subject: [PATCH] Special:Contributions/newbies was broken --- includes/SpecialContributions.php | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/includes/SpecialContributions.php b/includes/SpecialContributions.php index 0dda760f5a..3a5c90e1ae 100644 --- a/includes/SpecialContributions.php +++ b/includes/SpecialContributions.php @@ -26,9 +26,9 @@ class contribs_finder { list($index, $usercond) = $this->get_user_cond(); $use_index = $this->dbr->useIndexClause($index); - extract($this->dbr->tableNames('revision')); + extract($this->dbr->tableNames('revision', 'page')); $sql = "SELECT rev_timestamp " . - " FROM $revision $use_index " . + " FROM $page,$revision $use_index " . " WHERE " . $usercond . " ORDER BY rev_timestamp $dir LIMIT 1"; @@ -50,7 +50,7 @@ class contribs_finder { if ($this->username == 'newbies') { $max = $this->dbr->selectField('user', 'max(user_id)', false, "make_sql"); - $condition = '>' . ($max - $max / 100); + $condition = '>' . (int)($max - $max / 100); } if ($condition == "") { @@ -60,7 +60,6 @@ class contribs_finder { $condition = " rev_user {$condition}"; $index = 'user_timestamp'; } - return array($index, $condition); } @@ -163,7 +162,7 @@ function wfSpecialContributions( $par = null ) { $urlbits = "target=" . wfUrlEncode($target); $myurl = $title->escapeLocalURL($urlbits); - $finder = new contribs_finder($nt->getText()); + $finder = new contribs_finder(($target == 'newbies') ? 'newbies' : $nt->getText()); $finder->set_limit($limit); $finder->set_offset($offset); -- 2.20.1