From 8e4b41a50866e9503ed1498e6ac70b31c88d66ca Mon Sep 17 00:00:00 2001 From: Jeff Date: Sun, 20 Apr 2014 15:09:34 -0700 Subject: [PATCH] PostgreSQL: Allow rc_cur_time field to be null. The column recentchanges.rc_cur_time is no longer populated by SQL, so PostgreSQL must be changed to allow the NULL value for it. In MySQL, the empty string is used as a surrogate for NULL, but that is not allowed in PostgreSQL. Bug: 61318 Change-Id: I6733ef11152d545382bec087d992515dcf9aec0b --- includes/installer/PostgresUpdater.php | 1 + maintenance/postgres/tables.sql | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/includes/installer/PostgresUpdater.php b/includes/installer/PostgresUpdater.php index c5c10b381f..15e18ed966 100644 --- a/includes/installer/PostgresUpdater.php +++ b/includes/installer/PostgresUpdater.php @@ -234,6 +234,7 @@ class PostgresUpdater extends DatabaseUpdater { array( 'changeNullableField', 'image', 'img_metadata', 'NOT NULL' ), array( 'changeNullableField', 'filearchive', 'fa_metadata', 'NOT NULL' ), array( 'changeNullableField', 'recentchanges', 'rc_cur_id', 'NULL' ), + array( 'changeNullableField', 'recentchanges', 'rc_cur_time', 'NULL' ), array( 'checkOiDeleted' ), diff --git a/maintenance/postgres/tables.sql b/maintenance/postgres/tables.sql index 266cb3b22b..a3fb0421ee 100644 --- a/maintenance/postgres/tables.sql +++ b/maintenance/postgres/tables.sql @@ -406,7 +406,7 @@ CREATE SEQUENCE recentchanges_rc_id_seq; CREATE TABLE recentchanges ( rc_id INTEGER NOT NULL PRIMARY KEY DEFAULT nextval('recentchanges_rc_id_seq'), rc_timestamp TIMESTAMPTZ NOT NULL, - rc_cur_time TIMESTAMPTZ NOT NULL, + rc_cur_time TIMESTAMPTZ NULL, rc_user INTEGER NULL REFERENCES mwuser(user_id) ON DELETE SET NULL DEFERRABLE INITIALLY DEFERRED, rc_user_text TEXT NOT NULL, rc_namespace SMALLINT NOT NULL, -- 2.20.1