From 739f9fd485006b79ec11f674bc4e124f732330f9 Mon Sep 17 00:00:00 2001 From: Alexandre Emsenhuber Date: Mon, 8 Sep 2014 20:54:53 +0200 Subject: [PATCH] Avoid a fatal error in maintenance/cleanupTitles.php Title::makeTitleSafe() can return null; so only call exists() if an object was returned, and otherwise behave the same way as if the page existed: use another name. Change-Id: I75ea5c5b25fa5fdf6646a177a5fbccc0dbff9b47 --- maintenance/cleanupTitles.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/maintenance/cleanupTitles.php b/maintenance/cleanupTitles.php index eee1204668..0df9e7fe0c 100644 --- a/maintenance/cleanupTitles.php +++ b/maintenance/cleanupTitles.php @@ -156,7 +156,7 @@ class TitleCleanup extends TableCleanup { $clean = 'Broken/' . $prior; $verified = Title::makeTitleSafe( $ns, $clean ); - if ( $verified->exists() ) { + if ( !$verified || $verified->exists() ) { $blah = "Broken/id:" . $row->page_id; $this->output( "Couldn't legalize; form '$clean' exists; using '$blah'\n" ); $verified = Title::makeTitleSafe( $ns, $blah ); -- 2.20.1