From 478d42cc35eb507ecf2963173baad2f30cf9ed57 Mon Sep 17 00:00:00 2001 From: Reedy Date: Sat, 7 Apr 2012 17:23:16 +0100 Subject: [PATCH] Action::checkCanExecute doesn't return anything on success, but WatchAction returns the result Change-Id: Ib4169a8067f22f4a80295923e2aa77d151c4c47c --- includes/Action.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/includes/Action.php b/includes/Action.php index 84c0f808e7..a25e8aa9ab 100644 --- a/includes/Action.php +++ b/includes/Action.php @@ -266,6 +266,7 @@ abstract class Action { * * @param $user User: the user to check, or null to use the context user * @throws ErrorPageError + * @return bool True on success */ protected function checkCanExecute( User $user ) { $right = $this->getRestriction(); @@ -287,6 +288,7 @@ abstract class Action { if ( $this->requiresWrite() && wfReadOnly() ) { throw new ReadOnlyError(); } + return true; } /** -- 2.20.1