From: Brion Vibber <brion@users.mediawiki.org>
Date: Mon, 12 Dec 2011 06:27:20 +0000 (+0000)
Subject: * (bug 32958) SpecialAllMessages: input form doesn't show and remember filter option
X-Git-Tag: 1.31.0-rc.0~26059
X-Git-Url: http://git.cyclocoop.org/%24self?a=commitdiff_plain;h=bbde21f35a06779ae9eb55c915b19efa2f575941;p=lhc%2Fweb%2Fwiklou.git

* (bug 32958) SpecialAllMessages: input form doesn't show and remember filter option

Did this a little differently, but inspired by MrBlueSky's patch: https://bugzilla.wikimedia.org/attachment.cgi?id=9655

Rather than using the $this->custom values to check as in the patch, I moved $this->filter from the specialpage class (where it wasn't being used) to the pager class (where it was being used). Probably left over from a refactor.
---

diff --git a/includes/specials/SpecialAllmessages.php b/includes/specials/SpecialAllmessages.php
index 45ba4066ba..4f2b84d97f 100644
--- a/includes/specials/SpecialAllmessages.php
+++ b/includes/specials/SpecialAllmessages.php
@@ -62,9 +62,6 @@ class SpecialAllmessages extends SpecialPage {
 
 		$out->addModuleStyles( 'mediawiki.special' );
 
-		$this->filter = $request->getVal( 'filter', 'all' );
-		$this->prefix = $request->getVal( 'prefix', '' );
-
 		$this->table = new AllmessagesTablePager(
 			$this,
 			array(),
@@ -120,7 +117,8 @@ class AllmessagesTablePager extends TablePager {
 
 		$request = $this->getRequest();
 
-		if( $request->getVal( 'filter', 'all' ) === 'all' ){
+		$this->filter = $request->getVal( 'filter', 'all' );
+		if( $this->filter === 'all' ){
 			$this->custom = null; // So won't match in either case
 		} else {
 			$this->custom = ($request->getVal( 'filter' ) == 'unmodified');