From: Matthew Flaschen <mflaschen@wikimedia.org>
Date: Thu, 6 Jul 2017 23:14:38 +0000 (-0400)
Subject: Use shell_exec instead of backtick
X-Git-Tag: 1.31.0-rc.0~2745^2
X-Git-Url: http://git.cyclocoop.org/%24self?a=commitdiff_plain;h=5e6a3a418cf68a2972bf5a4469f0f35f694977ee;p=lhc%2Fweb%2Fwiklou.git

Use shell_exec instead of backtick

They are exactly equivalent, but shell_exec is more readable.
We just imported a sniff to forbid backtick into mediawiki-codesniffer.

It's not deployed here yet, but this will facilitate it.

Change-Id: I4b58ed78e1792ff83e1bf99425f8f19123cfe911
---

diff --git a/maintenance/mwdocgen.php b/maintenance/mwdocgen.php
index d0056299b2..43041a43df 100644
--- a/maintenance/mwdocgen.php
+++ b/maintenance/mwdocgen.php
@@ -105,7 +105,7 @@ class MWDocGen extends Maintenance {
 			$this->excludePatterns[] = 'extensions';
 		}
 
-		$this->doDot = `which dot`;
+		$this->doDot = shell_exec( 'which dot' );
 		$this->doMan = $this->hasOption( 'generate-man' );
 	}