From: Antoine Musso <hashar@users.mediawiki.org>
Date: Thu, 17 Nov 2011 10:10:40 +0000 (+0000)
Subject: skip Media: links in addition to Special: links
X-Git-Tag: 1.31.0-rc.0~26447
X-Git-Url: http://git.cyclocoop.org/%24self?a=commitdiff_plain;h=40a079166ab9b4151e318e2e4b3a6e9a00c32167;p=lhc%2Fweb%2Fwiklou.git

skip Media: links in addition to Special: links

That one triggered an exception stack trace when using Media:foo as
a target on Special:WhatLinksHere.

Example:
Special:WhatLinksHere/Media:file.png

That is a rare occurence that "should not happen". I am not sure it is
worth backporting to 1.18 although it impacts live site:

http://en.wikipedia.org/wiki/Special:WhatLinksHere/Media:BSicon_uBS2lf.svg
---

diff --git a/includes/SkinTemplate.php b/includes/SkinTemplate.php
index 7f20b66a2d..807921b727 100644
--- a/includes/SkinTemplate.php
+++ b/includes/SkinTemplate.php
@@ -814,7 +814,7 @@ class SkinTemplate extends Skin {
 		wfRunHooks( 'SkinTemplatePreventOtherActiveTabs', array( &$this, &$preventActiveTabs ) );
 
 		// Checks if page is some kind of content
-		if( !$title->isSpecialPage() ) {
+		if( $title->canExist() ) {
 			// Gets page objects for the related namespaces
 			$subjectPage = $title->getSubjectPage();
 			$talkPage = $title->getTalkPage();