From: Ævar Arnfjörð Bjarmason <avar@users.mediawiki.org>
Date: Wed, 7 Jul 2010 15:05:05 +0000 (+0000)
Subject: new-installer: Revert DB driver check breakage in r69128
X-Git-Tag: 1.31.0-rc.0~36220
X-Git-Url: http://git.cyclocoop.org/%24self?a=commitdiff_plain;h=16de3266d2dd404bc50ea50668b449a23565d069;p=lhc%2Fweb%2Fwiklou.git

new-installer: Revert DB driver check breakage in r69128

We should use isCompiled() to check if we can actually use a DB
driver. Just constructing the object isn't enough. r69128 regressed so
that the installed displayed Oracle as an option for me, even though I
have no driver for it.
---

diff --git a/includes/installer/Installer.php b/includes/installer/Installer.php
index 625c2efd69..2366ad21ed 100644
--- a/includes/installer/Installer.php
+++ b/includes/installer/Installer.php
@@ -404,7 +404,7 @@ abstract class Installer {
 		foreach ( $this->dbTypes as $name ) {
 			$db = $this->getDBInstaller( $name );
 			$readableName = wfMsg( 'config-type-' . $name );
-			if ( $db ) {
+			if ( $db->isCompiled() ) {
 				$compiledDBs[] = $name;
 				$goodNames[] = $readableName;
 			}