From: Brian Wolff <bawolff@users.mediawiki.org>
Date: Sat, 2 Oct 2010 20:36:23 +0000 (+0000)
Subject: Fix undefined variable notice if $wgHiddenPrefs[] = 'fancysig'.
X-Git-Tag: 1.31.0-rc.0~34671
X-Git-Url: http://git.cyclocoop.org/%24self?a=commitdiff_plain;h=0d5cd20121042f928a87aa35079c6418be1ba008;p=lhc%2Fweb%2Fwiklou.git

Fix undefined variable notice if $wgHiddenPrefs[] = 'fancysig'.

Use !empty($blah) since that is what the rest of the code is doing. This does
not change the behaviour in any way, only gets rid of the warning. Issue
discovered by jorenl on irc.
---

diff --git a/includes/Preferences.php b/includes/Preferences.php
index abb3f5c03f..6a16024fc4 100644
--- a/includes/Preferences.php
+++ b/includes/Preferences.php
@@ -1117,7 +1117,7 @@ class Preferences {
 
 	static function cleanSignature( $signature, $alldata ) {
 		global $wgParser;
-		if ( $alldata['fancysig'] ) {
+		if ( !empty( $alldata['fancysig'] ) ) {
 			$signature = $wgParser->cleanSig( $signature );
 		} else {
 			// When no fancy sig used, make sure ~{3,5} get removed.