new-installer: Revert DB driver check breakage in r69128
authorÆvar Arnfjörð Bjarmason <avar@users.mediawiki.org>
Wed, 7 Jul 2010 15:05:05 +0000 (15:05 +0000)
committerÆvar Arnfjörð Bjarmason <avar@users.mediawiki.org>
Wed, 7 Jul 2010 15:05:05 +0000 (15:05 +0000)
We should use isCompiled() to check if we can actually use a DB
driver. Just constructing the object isn't enough. r69128 regressed so
that the installed displayed Oracle as an option for me, even though I
have no driver for it.

includes/installer/Installer.php

index 625c2ef..2366ad2 100644 (file)
@@ -404,7 +404,7 @@ abstract class Installer {
                foreach ( $this->dbTypes as $name ) {
                        $db = $this->getDBInstaller( $name );
                        $readableName = wfMsg( 'config-type-' . $name );
-                       if ( $db ) {
+                       if ( $db->isCompiled() ) {
                                $compiledDBs[] = $name;
                                $goodNames[] = $readableName;
                        }