From fc4de495451f6e2662b5913081d03263edb988c2 Mon Sep 17 00:00:00 2001 From: Kunal Mehta Date: Tue, 27 Sep 2016 14:50:13 -0700 Subject: [PATCH] Make RecentChange::addTags() accept a string Most planned callers of RecentChange::addTags() only want to add a single tag, so forcing them to create an array seems unfriendly. Plus this lets us avoid a array_merge call. Change-Id: If001ba9ff01a33be158e7edd5c5e4de9825fa180 --- includes/changes/RecentChange.php | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/includes/changes/RecentChange.php b/includes/changes/RecentChange.php index 7ae1f29135..584c813bc8 100644 --- a/includes/changes/RecentChange.php +++ b/includes/changes/RecentChange.php @@ -1037,9 +1037,13 @@ class RecentChange { * * @since 1.28 * - * @param array $tags + * @param string|array $tags */ public function addTags( $tags ) { - $this->tags = array_merge( $tags, $this->tags ); + if ( is_string( $tags ) ) { + $this->tags[] = $tags; + } else { + $this->tags = array_merge( $tags, $this->tags ); + } } } -- 2.20.1