From c8d221a1e96b69e7c17571215ca7cc4a143b6ae8 Mon Sep 17 00:00:00 2001 From: Abhishek Das Date: Wed, 20 Feb 2013 15:50:28 +0530 Subject: [PATCH] Some minor coding practice fixes; There were a few lines in `SpecialVersion.php` that caused the build to be marked as failure. Fixing those: 1. Line 594 - String concat not required, so using single string instead Change-Id: I799d11aaaf953d09f681585ee23dc5bf496af3d4 --- includes/specials/SpecialVersion.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/includes/specials/SpecialVersion.php b/includes/specials/SpecialVersion.php index b04f1ef2d1..88d647e92b 100644 --- a/includes/specials/SpecialVersion.php +++ b/includes/specials/SpecialVersion.php @@ -594,8 +594,7 @@ class SpecialVersion extends SpecialPage { */ private function IPInfo() { $ip = str_replace( '--', ' - ', htmlspecialchars( $this->getRequest()->getIP() ) ); - return "\n" . - "visited from $ip"; + return "\nvisited from $ip"; } /** -- 2.20.1