From b4115ca9cf550c2e38dc0ef555f2f87d9d596453 Mon Sep 17 00:00:00 2001 From: Thiemo Kreuz Date: Fri, 10 May 2019 15:23:20 +0200 Subject: [PATCH] Remove unused title parameter from EditPage::getEditToolbar() No code uses this parameter: https://codesearch.wmflabs.org/search/?q=getEditToolbar I suggest to skip any deprecation because of this. It might be worth mentioning this in the release notes anyway, or is it? Change-Id: I5d47c22fa741df5f9c248e4e1bff2d6e97aca6a7 --- includes/EditPage.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/includes/EditPage.php b/includes/EditPage.php index 2d5b9e20b5..edc1cbeb07 100644 --- a/includes/EditPage.php +++ b/includes/EditPage.php @@ -2934,7 +2934,7 @@ ERROR; } if ( !$this->mTitle->isUserConfigPage() ) { - $out->addHTML( self::getEditToolbar( $this->mTitle ) ); + $out->addHTML( self::getEditToolbar() ); } if ( $this->blankArticle ) { @@ -4101,10 +4101,9 @@ ERROR; /** * Allow extensions to provide a toolbar. * - * @param Title|null $title Title object for the page being edited (optional) * @return string|null */ - public static function getEditToolbar( $title = null ) { + public static function getEditToolbar() { $startingToolbar = '
'; $toolbar = $startingToolbar; -- 2.20.1