From b058096a58a2eb3abd36bbd282c17f80b7db54bf Mon Sep 17 00:00:00 2001 From: umherirrender Date: Mon, 24 Feb 2014 18:17:35 +0100 Subject: [PATCH] Remove another ss_active_users check from SiteStats::isSane Also add a comment to method doc to make sure, nobody will add it again. Follow-Up: Id8f1cb7035ae0058fb34a6c7bdf7bf9f6c740a69 Follow-Up: I268599be96106e1175fdf9750a2adc9468ebc93c Change-Id: Ifd6da554b531720aace4497f7fbc2f58c12edc07 --- includes/SiteStats.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/includes/SiteStats.php b/includes/SiteStats.php index 6e2b5fa180..7169b2e2a9 100644 --- a/includes/SiteStats.php +++ b/includes/SiteStats.php @@ -221,6 +221,8 @@ class SiteStats { /** * Is the provided row of site stats sane, or should it be regenerated? * + * Checks only fields which are filled by SiteStatsInit::refresh. + * * @param $row * * @return bool @@ -229,7 +231,6 @@ class SiteStats { if ( $row === false || $row->ss_total_pages < $row->ss_good_articles || $row->ss_total_edits < $row->ss_total_pages - || $row->ss_users < $row->ss_active_users ) { return false; } -- 2.20.1