From 92b4b7340b8448d86460b8f773a2d4ab223f5440 Mon Sep 17 00:00:00 2001 From: Antoine Musso Date: Fri, 7 Dec 2012 16:39:39 +0100 Subject: [PATCH] worthwhile tests in testTitleObjectStringConversion The previous tests were not reflecting their comment, I have tweaked the assertions a bit to actually test something that reflect the comments. Change-Id: Ie1764ee1a218ead0169958704ba8625ab8d56445 --- tests/phpunit/includes/SampleTest.php | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/phpunit/includes/SampleTest.php b/tests/phpunit/includes/SampleTest.php index 45ea555098..88bbc070df 100644 --- a/tests/phpunit/includes/SampleTest.php +++ b/tests/phpunit/includes/SampleTest.php @@ -35,12 +35,11 @@ class TestSample extends MediaWikiLangTestCase { */ function testTitleObjectStringConversion() { $title = Title::newFromText("text"); - $this->assertEquals("Text", $title->__toString(), "Title creation"); - $this->assertEquals("Text", "Text", "Automatic string conversion"); + $this->assertInstanceOf('Title', $title, "Title creation"); + $this->assertEquals("Text", $title, "Automatic string conversion"); $title = Title::newFromText("text", NS_MEDIA); - $this->assertEquals("Media:Text", $title->__toString(), "Title creation with namespace"); - + $this->assertEquals("Media:Text", $title, "Title creation with namespace"); } /** -- 2.20.1