From 7b9a0ec232ffbd8ae7170404c9893d45572c1d82 Mon Sep 17 00:00:00 2001 From: umherirrender Date: Sat, 9 Feb 2013 16:12:09 +0100 Subject: [PATCH] Use OldLocalFile::selectFields() It is good practice to specifiy the fields in a select Change-Id: I3faa568ed6311a585da9161eccd8da3d065da250 --- includes/revisiondelete/RevisionDelete.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/includes/revisiondelete/RevisionDelete.php b/includes/revisiondelete/RevisionDelete.php index 5340cb9ec0..bd909d2bcb 100644 --- a/includes/revisiondelete/RevisionDelete.php +++ b/includes/revisiondelete/RevisionDelete.php @@ -454,7 +454,9 @@ class RevDel_FileList extends RevDel_List { foreach( $this->ids as $timestamp ) { $archiveNames[] = $timestamp . '!' . $this->title->getDBkey(); } - return $db->select( 'oldimage', '*', + return $db->select( + 'oldimage', + OldLocalFile::selectFields(), array( 'oi_name' => $this->title->getDBkey(), 'oi_archive_name' => $archiveNames -- 2.20.1