From 751f2b9d251d2c65a7a1f2c20af894790551d7f1 Mon Sep 17 00:00:00 2001
From: Timo Tijhof <krinklemail@gmail.com>
Date: Fri, 31 Mar 2017 18:03:17 -0700
Subject: [PATCH] objectcache: Complete code coverage for HashBagOStuff

Change-Id: I06cb9778df8239706bf82c0c39cccb419eade4b2
---
 .../libs/objectcache/HashBagOStuffTest.php    | 37 +++++++++++++++++--
 1 file changed, 34 insertions(+), 3 deletions(-)

diff --git a/tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php b/tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php
index c4db0cf8bf..f44baeb831 100644
--- a/tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php
+++ b/tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php
@@ -5,6 +5,40 @@
  */
 class HashBagOStuffTest extends PHPUnit_Framework_TestCase {
 
+	/**
+	 * @covers HashBagOStuff::__construct
+	 */
+	public function testConstruct() {
+		$this->assertInstanceOf(
+			HashBagOStuff::class,
+			new HashBagOStuff()
+		);
+	}
+
+	/**
+	 * @covers HashBagOStuff::__construct
+	 * @expectedException InvalidArgumentException
+	 */
+	public function testConstructBadZero() {
+		$cache = new HashBagOStuff( [ 'maxKeys' => 0 ] );
+	}
+
+	/**
+	 * @covers HashBagOStuff::__construct
+	 * @expectedException InvalidArgumentException
+	 */
+	public function testConstructBadNeg() {
+		$cache = new HashBagOStuff( [ 'maxKeys' => -1 ] );
+	}
+
+	/**
+	 * @covers HashBagOStuff::__construct
+	 * @expectedException InvalidArgumentException
+	 */
+	public function testConstructBadType() {
+		$cache = new HashBagOStuff( [ 'maxKeys' => 'x' ] );
+	}
+
 	/**
 	 * @covers HashBagOStuff::delete
 	 */
@@ -56,7 +90,6 @@ class HashBagOStuffTest extends PHPUnit_Framework_TestCase {
 	/**
 	 * Ensure maxKeys eviction prefers keeping new keys.
 	 *
-	 * @covers HashBagOStuff::__construct
 	 * @covers HashBagOStuff::set
 	 */
 	public function testEvictionAdd() {
@@ -76,7 +109,6 @@ class HashBagOStuffTest extends PHPUnit_Framework_TestCase {
 	 * Ensure maxKeys eviction prefers recently set keys
 	 * even if the keys pre-exist.
 	 *
-	 * @covers HashBagOStuff::__construct
 	 * @covers HashBagOStuff::set
 	 */
 	public function testEvictionSet() {
@@ -102,7 +134,6 @@ class HashBagOStuffTest extends PHPUnit_Framework_TestCase {
 	/**
 	 * Ensure maxKeys eviction prefers recently retrieved keys (LRU).
 	 *
-	 * @covers HashBagOStuff::__construct
 	 * @covers HashBagOStuff::doGet
 	 * @covers HashBagOStuff::hasKey
 	 */
-- 
2.20.1