From 6ca760a5bada5b60fc3fbf64c2890951097d3db2 Mon Sep 17 00:00:00 2001 From: Kevin Israel Date: Sun, 25 May 2014 09:12:00 -0400 Subject: [PATCH] Revert more visibility changes in HistoryBlob.php This follows-up bebcf2c58381, which only fixed DiffHistoryBlob. MediaWiki will fail to load some revisions if the following properties do not unserialize correctly: * HistoryBlobStub::$mOldId * HistoryBlobStub::$mHash * HistoryBlobCurStub::$mCurId Visibility of HistoryBlobStub::$mRef is also restored; though the property's value does not appear to be used after unserialization, the property is nevertheless a serialized property. Bug: 65665 Change-Id: I2724d15f9206d66d615d020117e60bb772048c19 --- includes/HistoryBlob.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/includes/HistoryBlob.php b/includes/HistoryBlob.php index 06e5ecc2bb..d0cae363fa 100644 --- a/includes/HistoryBlob.php +++ b/includes/HistoryBlob.php @@ -197,13 +197,13 @@ class HistoryBlobStub { protected static $blobCache = array(); /** @var int */ - protected $mOldId; + public $mOldId; /** @var string */ - protected $mHash; + public $mHash; /** @var */ - protected $mRef; + public $mRef; /** * @param string $hash The content hash of the text @@ -313,7 +313,7 @@ class HistoryBlobStub { */ class HistoryBlobCurStub { /** @var int */ - private $mCurId; + public $mCurId; /** * @param int $curid The cur_id pointed to -- 2.20.1