From 48a0666f45c8be8d5c5b7acd8dba6c627ad65949 Mon Sep 17 00:00:00 2001 From: Bryan Tong Minh Date: Sat, 14 May 2011 14:15:35 +0000 Subject: [PATCH] (bug 27864) Transcluding {{Special:Prefix}} with empty prefix now lists all pages. Removed All pages link which doesn't make sense Patch by Salvatore Ingala Put ST47 on the proper place in CREDITS --- CREDITS | 3 ++- RELEASE-NOTES-1.19 | 2 ++ includes/specials/SpecialPrefixindex.php | 8 +++++--- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/CREDITS b/CREDITS index 834f3b6324..9f76a0ddb8 100644 --- a/CREDITS +++ b/CREDITS @@ -134,10 +134,11 @@ following names for their contribution to the product. * René Kijewski * Robert Treat * RockMFR -* ST47 +* Salvatore Ingala * Scott Colcord * Simon Walker * Solitarius +* ST47 * Stefano Codari * Str4nd * svip diff --git a/RELEASE-NOTES-1.19 b/RELEASE-NOTES-1.19 index 180cb7b120..d9950d3185 100644 --- a/RELEASE-NOTES-1.19 +++ b/RELEASE-NOTES-1.19 @@ -35,6 +35,8 @@ used in Tiff files. the user a page named [[:]] already exists. * (bug 28960) Added more messages to Special:EmailUser. * (bug 23002) Imagelinks table not updated after imagemove. +* (bug 27864) Transcluding {{Special:Prefix}} with empty prefix now lists all + pages. === API changes in 1.19 === * (bug 27790) add query type for querymodules to action=paraminfo diff --git a/includes/specials/SpecialPrefixindex.php b/includes/specials/SpecialPrefixindex.php index ff66cbe1da..72d7e37947 100644 --- a/includes/specials/SpecialPrefixindex.php +++ b/includes/specials/SpecialPrefixindex.php @@ -56,7 +56,10 @@ class SpecialPrefixindex extends SpecialAllpages { ); $showme = ''; - if( isset( $par ) ){ + if ( $this->including() && ( $par == '' ) ) { + // Bug 27864: if transcluded, show all pages instead of the form + $showme = ' '; + } elseif( isset( $par ) ){ $showme = $par; } elseif( $prefix != '' ){ $showme = $prefix; @@ -201,8 +204,7 @@ class SpecialPrefixindex extends SpecialAllpages { ' . $nsForm . ' - ' . - $sk->linkKnown( $self, wfMsgHtml( 'allpages' ) ); + '; if( isset( $res ) && $res && ( $n == $this->maxPerPage ) && ( $s = $res->fetchObject() ) ) { $query = array( -- 2.20.1