From 41984162afebf441cd4661f0a969c2bfd903163c Mon Sep 17 00:00:00 2001 From: Umherirrender Date: Mon, 3 Jun 2019 21:11:10 +0200 Subject: [PATCH] Improve type hints to special page related classes Change-Id: I96e2ff2fbd6f69e83212b22cf107417014b665e1 --- includes/specialpage/ChangesListSpecialPage.php | 2 +- includes/specials/SpecialBlock.php | 2 +- includes/specials/SpecialPasswordPolicies.php | 2 +- includes/specials/SpecialProtectedtitles.php | 2 +- includes/specials/SpecialUncategorizedpages.php | 1 + 5 files changed, 5 insertions(+), 4 deletions(-) diff --git a/includes/specialpage/ChangesListSpecialPage.php b/includes/specialpage/ChangesListSpecialPage.php index a9debb3b89..3c9abb2ab5 100644 --- a/includes/specialpage/ChangesListSpecialPage.php +++ b/includes/specialpage/ChangesListSpecialPage.php @@ -1099,7 +1099,7 @@ abstract class ChangesListSpecialPage extends SpecialPage { * Register all the filters, including legacy hook-driven ones. * Then create a FormOptions object with options as specified by the user * - * @param array $parameters + * @param string $parameters * * @return FormOptions */ diff --git a/includes/specials/SpecialBlock.php b/includes/specials/SpecialBlock.php index 810fbd2c7e..ea4f18d287 100644 --- a/includes/specials/SpecialBlock.php +++ b/includes/specials/SpecialBlock.php @@ -751,7 +751,7 @@ class SpecialBlock extends FormSpecialPage { * * @param array $data * @param IContextSource $context - * @return bool|string + * @return bool|array */ public static function processForm( array $data, IContextSource $context ) { global $wgBlockAllowsUTEdit, $wgHideUserContribLimit; diff --git a/includes/specials/SpecialPasswordPolicies.php b/includes/specials/SpecialPasswordPolicies.php index 9bd855ac20..cc8753ceae 100644 --- a/includes/specials/SpecialPasswordPolicies.php +++ b/includes/specials/SpecialPasswordPolicies.php @@ -127,7 +127,7 @@ class SpecialPasswordPolicies extends SpecialPage { * Create a HTML list of password policies for $group * * @param array $policies Original $wgPasswordPolicy array - * @param array $group Group to format password policies for + * @param string $group Group to format password policies for * * @return string HTML list of all applied password policies */ diff --git a/includes/specials/SpecialProtectedtitles.php b/includes/specials/SpecialProtectedtitles.php index 00bfba946d..5dc49ea8c7 100644 --- a/includes/specials/SpecialProtectedtitles.php +++ b/includes/specials/SpecialProtectedtitles.php @@ -136,7 +136,7 @@ class SpecialProtectedtitles extends SpecialPage { /** * @param string $pr_level Determines which option is selected as default - * @return string Formatted HTML + * @return string|array * @private */ function getLevelMenu( $pr_level ) { diff --git a/includes/specials/SpecialUncategorizedpages.php b/includes/specials/SpecialUncategorizedpages.php index 9efa8032c8..ab83af1c92 100644 --- a/includes/specials/SpecialUncategorizedpages.php +++ b/includes/specials/SpecialUncategorizedpages.php @@ -30,6 +30,7 @@ use MediaWiki\MediaWikiServices; * @todo FIXME: Make $requestedNamespace selectable, unify all subclasses into one */ class UncategorizedPagesPage extends PageQueryPage { + /** @var int|false */ protected $requestedNamespace = false; function __construct( $name = 'Uncategorizedpages' ) { -- 2.20.1