From 349ca056b7abbcf8055c747a7d53b30a21b93565 Mon Sep 17 00:00:00 2001 From: addshore Date: Fri, 25 Sep 2015 16:22:22 +0100 Subject: [PATCH] Move LogFormatter test comment block This was missed in: https://gerrit.wikimedia.org/r/#/c/239783/ Ia5016c82c00dd7c35a6f1253d6e385b587ec485e Change-Id: Ibf537aaca2a0ca9d2c509499f6da5b9e51b06037 --- .../includes/changes/RecentChangeTest.php | 38 ------------------- .../includes/logging/LogFormatterTest.php | 38 +++++++++++++++++++ 2 files changed, 38 insertions(+), 38 deletions(-) diff --git a/tests/phpunit/includes/changes/RecentChangeTest.php b/tests/phpunit/includes/changes/RecentChangeTest.php index 4d1a936eaf..fd287b5355 100644 --- a/tests/phpunit/includes/changes/RecentChangeTest.php +++ b/tests/phpunit/includes/changes/RecentChangeTest.php @@ -41,44 +41,6 @@ class RecentChangeTest extends MediaWikiTestCase { $this->assertEquals( $expected, $rc->getAttributes() ); } - /** - * The testIrcMsgForAction* tests are supposed to cover the hacky - * LogFormatter::getIRCActionText / bug 34508 - * - * Third parties bots listen to those messages. They are clever enough - * to fetch the i18n messages from the wiki and then analyze the IRC feed - * to reverse engineer the $1, $2 messages. - * One thing bots can not detect is when MediaWiki change the meaning of - * a message like what happened when we deployed 1.19. $1 became the user - * performing the action which broke basically all bots around. - * - * Should cover the following log actions (which are most commonly used by bots): - * - block/block - * - block/unblock - * - block/reblock - * - delete/delete - * - delete/restore - * - newusers/create - * - newusers/create2 - * - newusers/autocreate - * - move/move - * - move/move_redir - * - protect/protect - * - protect/modifyprotect - * - protect/unprotect - * - protect/move_prot - * - upload/upload - * - merge/merge - * - import/upload - * - import/interwiki - * - * As well as the following Auto Edit Summaries: - * - blank - * - replace - * - rollback - * - undo - */ - /** * @covers RecentChange::parseParams */ diff --git a/tests/phpunit/includes/logging/LogFormatterTest.php b/tests/phpunit/includes/logging/LogFormatterTest.php index 5d8a258345..1816708a6e 100644 --- a/tests/phpunit/includes/logging/LogFormatterTest.php +++ b/tests/phpunit/includes/logging/LogFormatterTest.php @@ -307,6 +307,44 @@ class LogFormatterTest extends MediaWikiLangTestCase { ); } + /** + * The testIrcMsgForAction* tests are supposed to cover the hacky + * LogFormatter::getIRCActionText / bug 34508 + * + * Third parties bots listen to those messages. They are clever enough + * to fetch the i18n messages from the wiki and then analyze the IRC feed + * to reverse engineer the $1, $2 messages. + * One thing bots can not detect is when MediaWiki change the meaning of + * a message like what happened when we deployed 1.19. $1 became the user + * performing the action which broke basically all bots around. + * + * Should cover the following log actions (which are most commonly used by bots): + * - block/block + * - block/unblock + * - block/reblock + * - delete/delete + * - delete/restore + * - newusers/create + * - newusers/create2 + * - newusers/autocreate + * - move/move + * - move/move_redir + * - protect/protect + * - protect/modifyprotect + * - protect/unprotect + * - protect/move_prot + * - upload/upload + * - merge/merge + * - import/upload + * - import/interwiki + * + * As well as the following Auto Edit Summaries: + * - blank + * - replace + * - rollback + * - undo + */ + /** * @covers LogFormatter::getIRCActionComment * @covers LogFormatter::getIRCActionText -- 2.20.1