From 2e5d8734e79df74fe0d39bb0208475ba66d2b02d Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Mon, 3 Apr 2006 00:53:56 +0000 Subject: [PATCH] * (bug 5432) Fix inconsistencies in cookie names when using table prefixes --- RELEASE-NOTES | 2 ++ includes/User.php | 18 +++++++++--------- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index 6505652607..5de81d35fa 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -731,6 +731,8 @@ fully support the editing toolbar, but was found to be too confusing. enable it. * (bug 5277) Use audio/midi rather that audio/mid * (bug 5410) Use namespace name when a custom namespace's nstab-NS message is nonexistent +* (bug 5432) Fix inconsistencies in cookie names when using table prefixes + === Caveats === diff --git a/includes/User.php b/includes/User.php index e70bc72eb5..53a85bfb6f 100644 --- a/includes/User.php +++ b/includes/User.php @@ -1346,22 +1346,22 @@ class User { } function setCookies() { - global $wgCookieExpiration, $wgCookiePath, $wgCookieDomain, $wgCookieSecure, $wgDBname; + global $wgCookieExpiration, $wgCookiePath, $wgCookieDomain, $wgCookieSecure, $wgCookiePrefix; if ( 0 == $this->mId ) return; $this->loadFromDatabase(); $exp = time() + $wgCookieExpiration; $_SESSION['wsUserID'] = $this->mId; - setcookie( $wgDBname.'UserID', $this->mId, $exp, $wgCookiePath, $wgCookieDomain, $wgCookieSecure ); + setcookie( $wgCookiePrefix.'UserID', $this->mId, $exp, $wgCookiePath, $wgCookieDomain, $wgCookieSecure ); $_SESSION['wsUserName'] = $this->getName(); - setcookie( $wgDBname.'UserName', $this->getName(), $exp, $wgCookiePath, $wgCookieDomain, $wgCookieSecure ); + setcookie( $wgCookiePrefix.'UserName', $this->getName(), $exp, $wgCookiePath, $wgCookieDomain, $wgCookieSecure ); $_SESSION['wsToken'] = $this->mToken; if ( 1 == $this->getOption( 'rememberpassword' ) ) { - setcookie( $wgDBname.'Token', $this->mToken, $exp, $wgCookiePath, $wgCookieDomain, $wgCookieSecure ); + setcookie( $wgCookiePrefix.'Token', $this->mToken, $exp, $wgCookiePath, $wgCookieDomain, $wgCookieSecure ); } else { - setcookie( $wgDBname.'Token', '', time() - 3600 ); + setcookie( $wgCookiePrefix.'Token', '', time() - 3600 ); } } @@ -1370,17 +1370,17 @@ class User { * It will clean the session cookie */ function logout() { - global $wgCookiePath, $wgCookieDomain, $wgCookieSecure, $wgDBname; + global $wgCookiePath, $wgCookieDomain, $wgCookieSecure, $wgCookiePrefix; $this->loadDefaults(); $this->setLoaded( true ); $_SESSION['wsUserID'] = 0; - setcookie( $wgDBname.'UserID', '', time() - 3600, $wgCookiePath, $wgCookieDomain, $wgCookieSecure ); - setcookie( $wgDBname.'Token', '', time() - 3600, $wgCookiePath, $wgCookieDomain, $wgCookieSecure ); + setcookie( $wgCookiePrefix.'UserID', '', time() - 3600, $wgCookiePath, $wgCookieDomain, $wgCookieSecure ); + setcookie( $wgCookiePrefix.'Token', '', time() - 3600, $wgCookiePath, $wgCookieDomain, $wgCookieSecure ); # Remember when user logged out, to prevent seeing cached pages - setcookie( $wgDBname.'LoggedOut', wfTimestampNow(), time() + 86400, $wgCookiePath, $wgCookieDomain, $wgCookieSecure ); + setcookie( $wgCookiePrefix.'LoggedOut', wfTimestampNow(), time() + 86400, $wgCookiePath, $wgCookieDomain, $wgCookieSecure ); } /** -- 2.20.1