From 2ad96d59c8b8c6cde661628d779262efa93f477e Mon Sep 17 00:00:00 2001 From: =?utf8?q?Niklas=20Laxstr=C3=B6m?= Date: Fri, 20 Jan 2012 19:09:55 +0000 Subject: [PATCH] Can't PHP just DWIM? Ping r109628 --- includes/logging/LogFormatter.php | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/includes/logging/LogFormatter.php b/includes/logging/LogFormatter.php index 00c194b041..cae6cb9c35 100644 --- a/includes/logging/LogFormatter.php +++ b/includes/logging/LogFormatter.php @@ -178,10 +178,12 @@ class LogFormatter { * Fill in missing indexes with empty strings to avoid * incorrect renumbering. */ - $max = max( array_keys( $params ) ); - for ( $i = 4; $i < $max; $i++ ) { - if ( !isset( $params[$i] ) ) { - $params[$i] = ''; + if ( count( $params ) ) { + $max = max( array_keys( $params ) ); + for ( $i = 4; $i < $max; $i++ ) { + if ( !isset( $params[$i] ) ) { + $params[$i] = ''; + } } } return $params; -- 2.20.1