From 2967766734a0b3f1a0d22b296fd84367327259e6 Mon Sep 17 00:00:00 2001 From: gladoscc Date: Thu, 1 Jan 2015 20:58:49 +1100 Subject: [PATCH] Rename testBug32548Exponent to testExponentLineBreaking Fix for @todo Change-Id: I0dcef36fe9cee95ae320b535bac883d5e26ad140 --- tests/phpunit/includes/libs/JavaScriptMinifierTest.php | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/phpunit/includes/libs/JavaScriptMinifierTest.php b/tests/phpunit/includes/libs/JavaScriptMinifierTest.php index 26b81ccf05..149a28c19c 100644 --- a/tests/phpunit/includes/libs/JavaScriptMinifierTest.php +++ b/tests/phpunit/includes/libs/JavaScriptMinifierTest.php @@ -164,7 +164,7 @@ class JavaScriptMinifierTest extends PHPUnit_Framework_TestCase { ); } - public static function provideBug32548() { + public static function provideExponentLineBreaking() { return array( array( // This one gets interpreted all together by the prior code; @@ -183,14 +183,13 @@ class JavaScriptMinifierTest extends PHPUnit_Framework_TestCase { } /** - * @dataProvider provideBug32548 + * @dataProvider provideExponentLineBreaking * @covers JavaScriptMinifier::minify - * @todo give this test a real name explaining what is being tested here */ - public function testBug32548Exponent( $num ) { + public function testExponentLineBreaking( $num ) { // Long line breaking was being incorrectly done between the base and // exponent part of a number, causing a syntax error. The line should - // instead break at the start of the number. + // instead break at the start of the number. (T34548) $prefix = 'var longVarName' . str_repeat( '_', 973 ) . '='; $suffix = ',shortVarName=0;'; -- 2.20.1