From 27f5535e208b26e4aa9eddbe133939c9833af9a9 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Thu, 28 Mar 2019 18:06:59 -0700 Subject: [PATCH] Avoid calling setTransactionTicket() on a non-DataUpdate for sanity Change-Id: Idbdb8bb2b8d065c8c86308ef8964e64fcd8dc7fb --- includes/Storage/DerivedPageDataUpdater.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/includes/Storage/DerivedPageDataUpdater.php b/includes/Storage/DerivedPageDataUpdater.php index 9ce12b4b13..d5c1656505 100644 --- a/includes/Storage/DerivedPageDataUpdater.php +++ b/includes/Storage/DerivedPageDataUpdater.php @@ -1590,8 +1590,9 @@ class DerivedPageDataUpdater implements IDBAccessObject { $update->setRevision( $legacyRevision ); $update->setTriggeringUser( $triggeringUser ); } + if ( $options['defer'] === false ) { - if ( $options['transactionTicket'] !== null ) { + if ( $update instanceof DataUpdate && $options['transactionTicket'] !== null ) { $update->setTransactionTicket( $options['transactionTicket'] ); } $update->doUpdate(); -- 2.20.1