From 033ce4471d56acc473625f069ca3ed647e6923df Mon Sep 17 00:00:00 2001 From: withoutaname Date: Sun, 13 Jul 2014 00:19:43 -0700 Subject: [PATCH] Remove getFormFields(), onSubmit() and onSuccess() from FormlessAction Leftovers from the FormAction class which has since split off Change-Id: I519566205bd39f4c511b0418a0564e9ef1eec6d0 --- RELEASE-NOTES-1.24 | 2 ++ includes/actions/FormlessAction.php | 23 ----------------------- 2 files changed, 2 insertions(+), 23 deletions(-) diff --git a/RELEASE-NOTES-1.24 b/RELEASE-NOTES-1.24 index 8011044629..dc946e42d1 100644 --- a/RELEASE-NOTES-1.24 +++ b/RELEASE-NOTES-1.24 @@ -243,6 +243,8 @@ changes to languages because of Bugzilla reports. PHP compiler called hphpc. (deprecated since 1.22) * ApiResult::enableSizeCheck() and disableSizeCheck() are now obsolete. * Removed ResourceLoaderGetStartupModules hook. (deprecated since 1.23) +* Removed getFormFields(), onSubmit() and onSuccess() from FormlessAction, as + these were meant specifically for FormAction instead. ==== Renamed classes ==== * CLDRPluralRuleConverter_Expression to CLDRPluralRuleConverterExpression diff --git a/includes/actions/FormlessAction.php b/includes/actions/FormlessAction.php index 0039838afb..7b3a714ce2 100644 --- a/includes/actions/FormlessAction.php +++ b/includes/actions/FormlessAction.php @@ -35,29 +35,6 @@ abstract class FormlessAction extends Action { */ abstract public function onView(); - /** - * We don't want an HTMLForm - * @return bool - */ - protected function getFormFields() { - return false; - } - - /** - * @param array $data - * @return bool - */ - public function onSubmit( $data ) { - return false; - } - - /** - * @return bool - */ - public function onSuccess() { - return false; - } - public function show() { $this->setHeaders(); -- 2.20.1