From: Chad Horohoe <chadh@wikimedia.org>
Date: Tue, 22 Apr 2014 08:52:11 +0000 (-0700)
Subject: Remove useless comments from search output
X-Git-Tag: 1.31.0-rc.0~16106^2
X-Git-Url: http://git.cyclocoop.org/%24image?a=commitdiff_plain;h=d34e904e7e8b4038a4a1adaf26c3b78764c66966;p=lhc%2Fweb%2Fwiklou.git

Remove useless comments from search output

They show up when results are broken, but it's better to skip
the broken result entirely and not put in a pointless comment.

Change-Id: I691b04f31e2e439f9481c954f177e21b7f80ca2c
---

diff --git a/includes/specials/SpecialSearch.php b/includes/specials/SpecialSearch.php
index 61bb1cd873..0c4252e497 100644
--- a/includes/specials/SpecialSearch.php
+++ b/includes/specials/SpecialSearch.php
@@ -551,7 +551,7 @@ class SpecialSearch extends SpecialPage {
 		$profile = new ProfileSection( __METHOD__ );
 
 		if ( $result->isBrokenTitle() ) {
-			return "<!-- Broken link in search result -->\n";
+			return '';
 		}
 
 		$title = $result->getTitle();
@@ -583,7 +583,7 @@ class SpecialSearch extends SpecialPage {
 		// The least confusing at this point is to drop the result.
 		// You may get less results, but... oh well. :P
 		if ( $result->isMissingRevision() ) {
-			return "<!-- missing page " . htmlspecialchars( $title->getPrefixedText() ) . "-->\n";
+			return '';
 		}
 
 		// format redirects / relevant sections
@@ -783,7 +783,7 @@ class SpecialSearch extends SpecialPage {
 		$profile = new ProfileSection( __METHOD__ );
 
 		if ( $result->isBrokenTitle() ) {
-			return "<!-- Broken link in search result -->\n";
+			return '';
 		}
 
 		$title = $result->getTitle();