From: Aaron Schulz <aschulz@wikimedia.org>
Date: Thu, 18 Jul 2019 05:50:14 +0000 (-0700)
Subject: objectcache: fix WinCacheBagOStuf::doGet() is_string() check
X-Git-Tag: 1.34.0-rc.0~962^2
X-Git-Url: http://git.cyclocoop.org/%24image?a=commitdiff_plain;h=b10b19c654c414f9a07a69a835dcebc37e906412;p=lhc%2Fweb%2Fwiklou.git

objectcache: fix WinCacheBagOStuf::doGet() is_string() check

Allow integers to so that incr() and other cases work. This class
now passes all the unit tests again.

Change-Id: Ie7aae36180472a0e913fb8275bccee3fbc6fe7d9
---

diff --git a/includes/libs/objectcache/WinCacheBagOStuff.php b/includes/libs/objectcache/WinCacheBagOStuff.php
index d75b34437e..23da0bb624 100644
--- a/includes/libs/objectcache/WinCacheBagOStuff.php
+++ b/includes/libs/objectcache/WinCacheBagOStuff.php
@@ -32,7 +32,7 @@ class WinCacheBagOStuff extends BagOStuff {
 		$casToken = null;
 
 		$blob = wincache_ucache_get( $key );
-		if ( !is_string( $blob ) ) {
+		if ( !is_string( $blob ) && !is_int( $blob ) ) {
 			return false;
 		}