From: Stephane Bisson <sbisson@wikimedia.org>
Date: Fri, 22 Dec 2017 17:13:12 +0000 (-0500)
Subject: RCLFilters: support longer page names
X-Git-Tag: 1.31.0-rc.0~1120^2
X-Git-Url: http://git.cyclocoop.org/%24image?a=commitdiff_plain;h=99479cb219f2ebb2e0b2b96b8df8064a7e14d232;p=lhc%2Fweb%2Fwiklou.git

RCLFilters: support longer page names

* Make target page selector at least 400px wide
* Set the page name as title (tooltip)

Bug: T183484
Change-Id: Ife806c0b5e5c2ab6e9be32194804e89daaf8b71c
---

diff --git a/resources/Resources.php b/resources/Resources.php
index b4944298d2..2dd710de7a 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1842,6 +1842,7 @@ return [
 			'resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.LiveUpdateButtonWidget.less',
 			'resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.RcTopSectionWidget.less',
 			'resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.RclToOrFromWidget.less',
+			'resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.RclTargetPageWidget.less',
 			'resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.WatchlistTopSectionWidget.less',
 		],
 		'skinStyles' => [
diff --git a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.RclTargetPageWidget.less b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.RclTargetPageWidget.less
new file mode 100644
index 0000000000..2d92e27be1
--- /dev/null
+++ b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.RclTargetPageWidget.less
@@ -0,0 +1,3 @@
+.mw-rcfilters-ui-rclTargetPageWidget {
+	min-width: 400px;
+}
diff --git a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.RclToOrFromWidget.less b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.RclToOrFromWidget.less
index af01f6879b..d63f35b7c0 100644
--- a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.RclToOrFromWidget.less
+++ b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.RclToOrFromWidget.less
@@ -1,6 +1,4 @@
 .mw-rcfilters-ui-rclToOrFromWidget {
-	min-width: 340px;
-
 	// need to be very specific to override bg-color
 	&.oo-ui-dropdownWidget.oo-ui-widget-enabled {
 		.oo-ui-dropdownWidget-handle {
diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.RclTargetPageWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.RclTargetPageWidget.js
index d5c5e26ec9..527d790d6c 100644
--- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.RclTargetPageWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.RclTargetPageWidget.js
@@ -71,7 +71,9 @@
 	 * Respond to the model being updated
 	 */
 	mw.rcfilters.ui.RclTargetPageWidget.prototype.updateUiBasedOnModel = function () {
-		var title = mw.Title.newFromText( this.model.getValue() );
-		this.titleSearch.setValue( title ? title.toText() : this.model.getValue() );
+		var title = mw.Title.newFromText( this.model.getValue() ),
+			text = title ? title.toText() : this.model.getValue();
+		this.titleSearch.setValue( text );
+		this.titleSearch.setTitle( text );
 	};
 }( mediaWiki ) );