From: Moriel Schottlender <moriel@gmail.com>
Date: Fri, 18 Aug 2017 23:08:09 +0000 (-0700)
Subject: RCFilters: Add title attribute to [x] button
X-Git-Tag: 1.31.0-rc.0~2349^2
X-Git-Url: http://git.cyclocoop.org/%24image?a=commitdiff_plain;h=944bdda518d8094af507d804846a3e968694d9d6;p=lhc%2Fweb%2Fwiklou.git

RCFilters: Add title attribute to [x] button

For accessibility, add title attribute to the remove button in
the active filters area.

Bug: T173608
Change-Id: Idcf735e3b610345a8206f83fe5f8115900455cc2
---

diff --git a/languages/i18n/en.json b/languages/i18n/en.json
index 6126bbd6e7..6078b64124 100644
--- a/languages/i18n/en.json
+++ b/languages/i18n/en.json
@@ -1350,6 +1350,7 @@
 	"recentchanges-legend-unpatrolled": "{{int:recentchanges-label-unpatrolled}}",
 	"recentchanges-legend-plusminus": "(<em>±123</em>)",
 	"recentchanges-submit": "Show",
+	"rcfilters-tag-remove": "Remove '$1'",
 	"rcfilters-legend-heading": "<strong>List of abbreviations:</strong>",
 	"rcfilters-other-review-tools": "<strong>Other review tools</strong>",
 	"rcfilters-group-results-by-page": "Group results by page",
diff --git a/languages/i18n/qqq.json b/languages/i18n/qqq.json
index bc0fe2c657..1bcb075862 100644
--- a/languages/i18n/qqq.json
+++ b/languages/i18n/qqq.json
@@ -1540,6 +1540,7 @@
 	"recentchanges-legend-unpatrolled": "Used as legend on [[Special:RecentChanges]] and [[Special:Watchlist]].\n\nRefers to {{msg-mw|Recentchanges-label-unpatrolled}}.",
 	"recentchanges-legend-plusminus": "{{optional}}\nA plus/minus sign with a number for the legend.",
 	"recentchanges-submit": "Label for submit button in [[Special:RecentChanges]]\n{{Identical|Show}}",
+	"rcfilters-tag-remove": "A tooltip for the button that removes a filter from the active filters area in [[Special:RecentChanges]] and [[Special:Watchlist]] when RCFilters are enabled. \n\nParameters: $1 - Tag label",
 	"rcfilters-legend-heading": "Used as a heading for legend box on [[Special:RecentChanges]] and [[Special:Watchlist]] when RCFilters are enabled.",
 	"rcfilters-other-review-tools": "Used as a heading for the community collection of other links on [[Special:RecentChanges]] when RCFilters are enabled.",
 	"rcfilters-group-results-by-page": "A label for the checkbox describing whether the results in [[Special:RecentChanges]] are grouped by page when RCFilters are enabled.",
diff --git a/resources/Resources.php b/resources/Resources.php
index c0c5d9ed27..6be211ecfd 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1832,6 +1832,7 @@ return [
 			],
 		],
 		'messages' => [
+			'rcfilters-tag-remove',
 			'rcfilters-activefilters',
 			'rcfilters-advancedfilters',
 			'rcfilters-group-results-by-page',
diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.TagItemWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.TagItemWidget.js
index bf75149706..81889b26ca 100644
--- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.TagItemWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.TagItemWidget.js
@@ -48,6 +48,9 @@
 		this.$highlight = $( '<div>' )
 			.addClass( 'mw-rcfilters-ui-tagItemWidget-highlight' );
 
+		// Add title attribute with the item label to 'x' button
+		this.closeButton.setTitle( mw.msg( 'rcfilters-tag-remove', this.model.getLabel() ) );
+
 		// Events
 		this.model.connect( this, { update: 'onModelUpdate' } );