From: Rob Church <robchurch@users.mediawiki.org>
Date: Fri, 5 May 2006 12:45:08 +0000 (+0000)
Subject: (bug 5791) Fix SQL syntax in Special:BrokenRedirects, was causing incorrect data... 
X-Git-Tag: 1.31.0-rc.0~57233
X-Git-Url: http://git.cyclocoop.org/%24image?a=commitdiff_plain;h=8e625b59c504fe0c74aeae986bf61441511ff23e;p=lhc%2Fweb%2Fwiklou.git

(bug 5791) Fix SQL syntax in Special:BrokenRedirects, was causing incorrect data to show
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index aff29f484b..d6b0306de3 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -216,6 +216,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * Clean up Special:Imagelist a bit
 * (bug 5838) Namespace names for Nds-NL
 * (bug 5749) Added Tyvan language files
+* (bug 5791) Fix SQL syntax in Special:BrokenRedirects, was causing incorrect data to show
 
 == Compatibility ==
 
diff --git a/includes/SpecialBrokenRedirects.php b/includes/SpecialBrokenRedirects.php
index 72b4211711..8c16e50a25 100644
--- a/includes/SpecialBrokenRedirects.php
+++ b/includes/SpecialBrokenRedirects.php
@@ -41,8 +41,8 @@ class BrokenRedirectsPage extends PageQueryPage {
 		                pl_title
 		           FROM $pagelinks AS pl
                    JOIN $page p1 ON (p1.page_is_redirect=1 AND pl.pl_from=p1.page_id)
-		      LEFT JOIN $page AS p2 ON (pl_namespace=p2.page_namespace AND pl_title=p2.page_title
-    		                AND p2.page_namespace IS NULL)";
+		      LEFT JOIN $page AS p2 ON (pl_namespace=p2.page_namespace AND pl_title=p2.page_title )
+    		                WHERE p2.page_namespace IS NULL";
 		return $sql;
 	}