From: Derk-Jan Hartman <hartman.wiki@gmail.com>
Date: Wed, 10 Jun 2015 23:50:25 +0000 (+0200)
Subject: Live preview: Don't show empty summary preview
X-Git-Tag: 1.31.0-rc.0~11110^2
X-Git-Url: http://git.cyclocoop.org/%24image?a=commitdiff_plain;h=88c16d8092f6501c7b697b24de913632eaa8e553;p=lhc%2Fweb%2Fwiklou.git

Live preview: Don't show empty summary preview

Change-Id: I4334d02cb460fd0f995ba16f1170dd8500744692
---

diff --git a/resources/src/mediawiki.action/mediawiki.action.edit.preview.js b/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
index 6026a8c019..5f1058f14b 100644
--- a/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
+++ b/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
@@ -211,19 +211,18 @@
 		}
 		request.done( function ( response ) {
 			var isSubject = ( section === 'new' ),
-				summaryMsg = isSubject ? 'subject-preview' : 'summary-preview';
-			if ( response.parse.parsedsummary ) {
-				$editform.find( '.mw-summary-preview' )
-					.empty()
-					.append(
-						mw.message( summaryMsg ).parse(),
-						' ',
-						$( '<span>' ).addClass( 'comment' ).html(
-							// There is no equivalent to rawParams
-							mw.message( 'parentheses' ).escaped()
-								.replace( '$1', response.parse.parsedsummary['*'] )
-						)
-					);
+				summaryMsg = isSubject ? 'subject-preview' : 'summary-preview',
+				$summaryPreview = $editform.find( '.mw-summary-preview' ).empty();
+			if ( response.parse.parsedsummary && response.parse.parsedsummary['*'] !== '' ) {
+				$summaryPreview.append(
+					mw.message( summaryMsg ).parse(),
+					' ',
+					$( '<span>' ).addClass( 'comment' ).html(
+						// There is no equivalent to rawParams
+						mw.message( 'parentheses' ).escaped()
+							.replace( '$1', response.parse.parsedsummary['*'] )
+					)
+				);
 			}
 			mw.hook( 'wikipage.editform' ).fire( $editform );
 		} );