From: Moriel Schottlender <moriel@gmail.com>
Date: Fri, 12 May 2017 00:52:45 +0000 (-0700)
Subject: RCFilters: Treat saved query with multiple spaces as empty
X-Git-Tag: 1.31.0-rc.0~3264^2
X-Git-Url: http://git.cyclocoop.org/%24image?a=commitdiff_plain;h=834882dfa05e1c760f947d23da93a0b49f2d7054;p=lhc%2Fweb%2Fwiklou.git

RCFilters: Treat saved query with multiple spaces as empty

Because it is empty, even if there's multiple spaces. Also, if the
input is invalid and we didn't save the query, don't close the
popup.

Bug: T165113
Change-Id: I30e68b0b90e2a4077fb4068c1462d40b03cbfe8c
---

diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
index 9b7a2fba8b..3f920f0013 100644
--- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
@@ -39,7 +39,7 @@
 		this.popup.$head.prepend( ( new OO.ui.IconWidget( { icon: 'clip' } ) ).$element );
 
 		this.input = new OO.ui.TextInputWidget( {
-			validate: 'non-empty'
+			validate: /\S/
 		} );
 		layout = new OO.ui.FieldLayout( this.input, {
 			label: mw.msg( 'rcfilters-savedqueries-new-name-label' ),
@@ -151,8 +151,6 @@
 				widget.controller.saveCurrentQuery( label );
 				widget.input.setValue( this.input, '' );
 				widget.emit( 'saveCurrent' );
-			} )
-			.always( function () {
 				widget.popup.toggle( false );
 			} );
 	};