From: Platonides <platonides@users.mediawiki.org>
Date: Sun, 19 Jun 2011 18:53:55 +0000 (+0000)
Subject: Follow up r90334.
X-Git-Tag: 1.31.0-rc.0~29413
X-Git-Url: http://git.cyclocoop.org/%24image?a=commitdiff_plain;h=71a0ad01017752e389d415f99bbfe05e530ceb99;p=lhc%2Fweb%2Fwiklou.git

Follow up r90334.
Removes the space after the class name in $wgBetterDirectionality = false,
I think it is clearer to have the variable to hold the classes, instead of the *additional* classes.
Renamed to be clearer and be camelCase.
Added redundant htmlspecialchars() and spaces.
---

diff --git a/includes/diff/DifferenceEngine.php b/includes/diff/DifferenceEngine.php
index 69d8994f3d..542847772d 100644
--- a/includes/diff/DifferenceEngine.php
+++ b/includes/diff/DifferenceEngine.php
@@ -937,14 +937,14 @@ CONTROL;
 	 */
 	static function addHeader( $diff, $otitle, $ntitle, $multi = '', $notice = '' ) {
 		global $wgBetterDirectionality, $wgTitle;
-		$dirclass = '';
+		$tableClass = 'diff';
 		if( $wgBetterDirectionality ) {
 			// shared.css sets diff in interface language/dir,
 			// but the actual content should be in the page language/dir
 			$pageLang = $wgTitle->getPageLanguage();
-			$dirclass = ' diff-contentalign-'.$pageLang->alignStart();
+			$tableClass .= ' diff-contentalign-' . htmlspecialchars( $pageLang->alignStart() );
 		}
-		$header = "<table class='diff $dirclass'>";
+		$header = "<table class='$tableClass'>";
 		if ( $diff ) { // Safari/Chrome show broken output if cols not used
 			$header .= "
 			<col class='diff-marker' />