From: Rotem Liss <rotem@users.mediawiki.org>
Date: Mon, 25 Feb 2008 06:42:12 +0000 (+0000)
Subject: (bug 13132) Unable to unprotect pages protected with earlier versions of MediaWiki
X-Git-Tag: 1.31.0-rc.0~49376
X-Git-Url: http://git.cyclocoop.org/%24image?a=commitdiff_plain;h=3d63f7a05b1f1ddd145cfb02c7fe3b279aa129ce;p=lhc%2Fweb%2Fwiklou.git

(bug 13132) Unable to unprotect pages protected with earlier versions of MediaWiki
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index d23a305a8d..78a3dd4d13 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -36,6 +36,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * (bug 10677) Add link to the file description page on the shared repository
 * (bug 13084) Increase size of source/destination filename fields in upload form
 * (bug 13115) rebuildrecentchanges should print the current value of $wgRCMaxAge
+* (bug 13132) Unable to unprotect pages protected with earlier versions of MediaWiki
 
 === API changes in 1.13 ===
 
diff --git a/includes/Article.php b/includes/Article.php
index 0544db7d02..12e174c9f7 100644
--- a/includes/Article.php
+++ b/includes/Article.php
@@ -1779,18 +1779,11 @@ class Article {
 							array( 'pr_page' => $id, 'pr_type' => $action
 								, 'pr_level' => $restrictions, 'pr_cascade' => $cascade ? 1 : 0
 								, 'pr_expiry' => $encodedExpiry ), __METHOD__  );
-						if($dbw->affectedRows() != 0)
-							$rowsAffected = true;
 					} else {
 						$dbw->delete( 'page_restrictions', array( 'pr_page' => $id,
 							'pr_type' => $action ), __METHOD__ );
-						if($dbw->affectedRows() != 0)
-							$rowsAffected = true;
 					}
 				}
-				if(!$rowsAffected)
-					// No change
-					return true;
 
 				# Insert a null revision
 				$nullRevision = Revision::newNullRevision( $dbw, $id, $comment, true );