From: Chad Horohoe <demon@users.mediawiki.org>
Date: Tue, 8 Jul 2008 14:49:58 +0000 (+0000)
Subject: Wikibits no longer uses document.write() (fixes bug 2186).
X-Git-Tag: 1.31.0-rc.0~46630
X-Git-Url: http://git.cyclocoop.org/%24image?a=commitdiff_plain;h=312a067a26885bcee6ba2502729e3eef192863db;p=lhc%2Fweb%2Fwiklou.git

Wikibits no longer uses document.write() (fixes bug 2186).
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index eb5a9a75a7..d6f4af089a 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -425,6 +425,8 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * (bug 14745) Image moving works on sites that transform thumbnails via 404
 * (bug 14159) Use of MEMCACHE_COMPRESSED constant no longer causes E_NOTICE 
   on PHP installs with the Memcache module installed.
+* (bug 2186) Document.write() in wikibits caused failures when using
+  application/xhtml+xml. The calls to this have been removed.
 
 === API changes in 1.13 ===
 
diff --git a/skins/common/wikibits.js b/skins/common/wikibits.js
index 373c8eedb4..e876e7db7c 100644
--- a/skins/common/wikibits.js
+++ b/skins/common/wikibits.js
@@ -86,14 +86,14 @@ function appendCSS(text) {
 	return s;
 }
 
-// document.write special stylesheet links
+// special stylesheet links
 if (typeof stylepath != 'undefined' && typeof skin != 'undefined') {
 	if (is_opera_preseven) {
-		document.write('<link rel="stylesheet" type="text/css" href="'+stylepath+'/'+skin+'/Opera6Fixes.css">');
+		importStylesheetURI(stylepath+'/'+skin+'/Opera6Fixes.css');
 	} else if (is_opera_seven && !is_opera_95) {
-		document.write('<link rel="stylesheet" type="text/css" href="'+stylepath+'/'+skin+'/Opera7Fixes.css">');
+		importStylesheetURI(stylepath+'/'+skin+'/Opera7Fixes.css');
 	} else if (is_khtml) {
-		document.write('<link rel="stylesheet" type="text/css" href="'+stylepath+'/'+skin+'/KHTMLFixes.css">');
+		importStylesheetURI(stylepath+'/'+skin+'/KHTMLFixes.css');
 	}
 }