From: aude Date: Thu, 24 Jul 2014 13:48:37 +0000 (+0200) Subject: Remove @todo in SpecialPage for making it into ContextSource X-Git-Tag: 1.31.0-rc.0~14507 X-Git-Url: http://git.cyclocoop.org/%24image?a=commitdiff_plain;h=287e641483e62c0e3070d3f35601f5c62f41eaf7;p=lhc%2Fweb%2Fwiklou.git Remove @todo in SpecialPage for making it into ContextSource It is better to have $context as a member variable, which can be accessed, $special->getContext(), as needed with a composition approach instead of inheritance. Having SpecialPage directly inherit makes testing code a bit more challenging and messy. Change-Id: I5e5587cbbc9abfb2fa4ab1e7603cd2ddcad1b96d --- diff --git a/includes/specialpage/SpecialPage.php b/includes/specialpage/SpecialPage.php index a72b2975e8..4edd87adba 100644 --- a/includes/specialpage/SpecialPage.php +++ b/includes/specialpage/SpecialPage.php @@ -27,7 +27,6 @@ * Includes some static functions for handling the special page list deprecated * in favor of SpecialPageFactory. * - * @todo Turn this into a real ContextSource * @ingroup SpecialPage */ class SpecialPage {