(bug 23797) Xml::input() now allows '0' for the value parameter

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 2e1e67d..ab91f93 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -189,6 +189,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
   the $noRedir parameter is set to true
 * (bug 23688) Correct mime types for Office 2007 OpenXML documents.
 * (bug 23787) Corrected $wgDefaultSkin's comment in DefaultSettings.php
+* (bug 23797) Xml::input() now allows '0' for the value parameter
 
 === API changes in 1.17 ===
 * (bug 22738) Allow filtering by action type on query=logevent.

diff --git a/includes/Xml.php b/includes/Xml.php
index d3dc5ab..22df176 100644 (file)
--- a/includes/Xml.php
+++ b/includes/Xml.php
@@ -280,7 +280,7 @@ class Xml {
                        $attributes['size'] = $size;
                }
 
-               if( $value ) {
+               if( $value !== false ) { // maybe 0
                        $attributes['value'] = $value;
                }