el_to should be varchar in oracle

check return from oci_new_descriptor

diff --git a/includes/DatabaseOracle.php b/includes/DatabaseOracle.php
index 7560039..20aff7f 100644 (file)
--- a/includes/DatabaseOracle.php
+++ b/includes/DatabaseOracle.php
@@ -331,7 +331,11 @@ class DatabaseOracle extends Database {
                        }
                }
 
-               $bval = oci_new_descriptor($this->mConn, OCI_D_LOB);
+               if (($bval = oci_new_descriptor($this->mConn, OCI_D_LOB)) === false) {
+                       $e = oci_error($stmt);
+                       throw new DBUnexpectedError($this, "Cannot create LOB descriptor: " . $e['message']);
+               }
+
                if (strlen($returning))
                        oci_bind_by_name($stmt, ":bval", $bval, -1, SQLT_BLOB);
 

diff --git a/maintenance/ora/tables.sql b/maintenance/ora/tables.sql
index f8ffc55..7273436 100644 (file)
--- a/maintenance/ora/tables.sql
+++ b/maintenance/ora/tables.sql
@@ -163,7 +163,7 @@ CREATE INDEX cl_sortkey     ON categorylinks (cl_to, cl_sortkey);
 
 CREATE TABLE externallinks (
   el_from   INTEGER  NOT NULL  REFERENCES page(page_id) ON DELETE CASCADE,
-  el_to     CLOB     NOT NULL,
+  el_to     VARCHAR(2048) NOT NULL,
   el_index  CLOB     NOT NULL
 );
 -- XXX CREATE INDEX externallinks_from_to ON externallinks (el_from,el_to);