* Don't use assignment in a condition check

* Pass the Title object so that it doesn't rely on $wgTitle

diff --git a/includes/Article.php b/includes/Article.php
index 82bef47..40a2c4f 100644 (file)
--- a/includes/Article.php
+++ b/includes/Article.php
@@ -1033,10 +1033,11 @@ class Article {
                # tents of 'pagetitle-view-mainpage' instead of the default (if
                # that's not empty).
                # This message always exists because it is in the i18n files
-               if ( $this->mTitle->equals( Title::newMainPage() )
-                       && ( $m = wfMsgForContent( 'pagetitle-view-mainpage' ) ) !== '' )
-               {
-                       $wgOut->setHTMLTitle( $m );
+               if ( $this->mTitle->equals( Title::newMainPage() ) ) {
+                       $msg = wfMessage( 'pagetitle-view-mainpage' )->inContentLanguage();
+                       if ( !$msg->isDisabled() ) {
+                               $wgOut->setHTMLTitle( $msg->title( $this->mTitle )->text() );
+                       }
                }
 
                # Now that we've filled $this->mParserOutput, we know whether